Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OSX architecture detection #821

Merged

Conversation

sajmonr
Copy link
Contributor

@sajmonr sajmonr commented Nov 4, 2023

The platform information will detect whether the process is x64 or arm64 and will report correct runtime ID to the publish command.

This PR resolves #820.

Copy link
Collaborator

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FlorianRappl FlorianRappl merged commit 3476145 into ElectronNET:main Feb 14, 2024
@sajmonr sajmonr deleted the feature/osx-architecture-detection branch February 17, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Platform detection is not differentiating between x64 and arm64 OSX platform
2 participants