Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid collecting v #33

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

gdalle
Copy link
Contributor

@gdalle gdalle commented Oct 23, 2024

Here's a proposal fixing JuliaDiff/DifferentiationInterface.jl#594 (comment)

You probably want to add test cases with ComponentArrays to your test suite

@ElOceanografo
Copy link
Owner

Thanks for the quick PR! Glad the collecting was an easy fix, I added it recently to work around some ComponentArray-related bug that I must have fixed another way.

@ElOceanografo ElOceanografo merged commit 86e6be7 into ElOceanografo:master Oct 23, 2024
2 checks passed
@gdalle gdalle deleted the no_collect branch October 23, 2024 11:47
@gdalle
Copy link
Contributor Author

gdalle commented Oct 23, 2024

You don't have ComponentArrays among your test extras though, are you sure you're testing those properly?

@ElOceanografo
Copy link
Owner

I currently have it as a direct dependency, since I need to dispatch on ComponentArray for an index-handling function here.

@gdalle
Copy link
Contributor Author

gdalle commented Oct 23, 2024

Sure but do you run some of your tests on ComponentArrays ?

@ElOceanografo
Copy link
Owner

Planning to add more, but yes, I've got basic ones e.g. here and here. That's how I caught this issue ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants