Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade Sphinx to 7.1.2 #773

Merged
merged 4 commits into from
Sep 9, 2023
Merged

chore: downgrade Sphinx to 7.1.2 #773

merged 4 commits into from
Sep 9, 2023

Conversation

lupino3
Copy link
Member

@lupino3 lupino3 commented Sep 8, 2023

This should fix the snapcraft build, which for some reason isn't finding Sphinx 7.2.2

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2023

Codecov Report

Merging #773 (7d1ae27) into master (9cdb265) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #773   +/-   ##
=========================================
  Coverage     51.14%   51.14%           
  Complexity     1447     1447           
=========================================
  Files           249      249           
  Lines          9879     9879           
  Branches       1092     1092           
=========================================
  Hits           5053     5053           
  Misses         4507     4507           
  Partials        319      319           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cdb265...7d1ae27. Read the comment docs.

@github-actions github-actions bot temporarily deployed to 773 September 8, 2023 08:20 Destroyed
This is needed for recent Sphinx versions.
@github-actions github-actions bot temporarily deployed to 773 September 9, 2023 15:48 Destroyed
@lupino3 lupino3 changed the title chore: update Sphinx to 7.2.5 chore: downgrade Sphinx to 7.1.2 Sep 9, 2023
@github-actions github-actions bot temporarily deployed to 773 September 9, 2023 16:16 Destroyed
@github-actions github-actions bot temporarily deployed to 773 September 9, 2023 16:27 Destroyed
@lupino3
Copy link
Member Author

lupino3 commented Sep 9, 2023

I don't get how it's still trying to install 7.2.2 on GitHub Actions

> Task :pipInstall
[python] .gradle/python/bin/python -m pip install sphinx==7.2.2
	 ERROR: Could not find a version that satisfies the requirement sphinx==7.2.2
	 ERROR: No matching distribution found for sphinx==7.2.2
	 WARNING: You are using pip version 21.0.1; however, version 23.2.1 is available.
	 You should consider upgrading via the '/root/parts/edumips64/build/.gradle/python/bin/python -m pip install --upgrade pip' command.

@lupino3
Copy link
Member Author

lupino3 commented Sep 9, 2023

I wonder if there is some caching going on. I'll merge the PR and see if it fixes master.

@lupino3 lupino3 merged commit 846386e into master Sep 9, 2023
@lupino3 lupino3 deleted the update-sphinx branch September 9, 2023 16:32
@lupino3
Copy link
Member Author

lupino3 commented Sep 9, 2023

lupino3 added a commit that referenced this pull request Sep 10, 2023
lupino3 added a commit that referenced this pull request Sep 10, 2023
* chore(deps): update all non-major dependencies

* Revert Sphinx change

see #773.

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Andrea Spadaccini <andrea.spadaccini@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants