Rest communication secure multiple process #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 22, 2018 10:53
…fferent session Ensure the lock is released just after the request has completed. Close all session upon deletion of the Communicator
lukbut
reviewed
Nov 22, 2018
| if self._session is None: | ||
| self._session = self.begin_session() | ||
| return self._session | ||
| pid = os.getpid() |
There was a problem hiding this comment.
Maybe add some comments to explain this process please, and possibly logs so we can peek into how this is working?
| @@ -97,6 +103,28 @@ def test_req(self, mocked_request): | |||
| assert json.loads(response.content.decode('utf-8')) == response.json() == test_nested_request_content | |||
| mocked_request.assert_called_with('METHOD', rest_url(test_endpoint), json=json_content) | |||
|
|
|||
| @patched_failed_request | |||
| def test_failed_req(self, mocked_request): | |||
mwhamgenomics
approved these changes
Nov 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new session for every new process to avoid SSL errors.
Also ensure the lock is released in the event of an exception occurring during the request
See psf/requests#4323 and
https://stackoverflow.com/questions/3724900/python-ssl-problem-with-multiprocessing/3724938#3724938
fixes #91