Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bw): radio tools list may display incorrect names #5806

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Jan 20, 2025

Fixes buffer overflows in B&W Radio Tools page.

To reproduce copy a large set of .lua tool scripts to the SCRIPTS/TOOLS folder on a B&W radio.

@philmoz philmoz added UX-UI Related to user experience (UX) or user interface (UI) behaviour B&W Related generally to black and white LCD radios bug/regression ↩️ A new version of EdgeTX broke something labels Jan 20, 2025
@philmoz philmoz added this to the 2.11 milestone Jan 20, 2025
@pfeerick pfeerick changed the title fix(b&w): radio tools list may display incorrect names. fix(bw): radio tools list may display incorrect names Jan 20, 2025
@pfeerick
Copy link
Member

Could that have also result in gaps in names? As I noticed the Wizard Loader had a missing letter and weird gap in it's name... like Wizard L ader

@philmoz
Copy link
Collaborator Author

philmoz commented Jan 20, 2025

Possibly. Code was using memory outside the defined radioTools.script array in reusableBuffer so it was being randomly overwritten by other things.

@pfeerick
Copy link
Member

Yup, that fixed it... Thanks! :)

@pfeerick pfeerick merged commit c4646cf into main Jan 20, 2025
49 checks passed
@pfeerick pfeerick deleted the philmoz/fix-bw-radio-tools branch January 20, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B&W Related generally to black and white LCD radios bug/regression ↩️ A new version of EdgeTX broke something UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants