chore: audio drivers cleanup #5789

raphaelcoeffic · 2025-01-15T11:28:29Z

Summary of changes:

removed unnecessary interrupt disable/re-enable
removed unnecessary bit shift for DAC audio by switching to "left-aligned" format
moved basic audio interface definition into hal/audio_driver.h
moved code for Xlites' shared DSC / audio jack into own files

3djc · 2025-01-16T15:03:48Z

Looks good to me, tested on T15 and GX12

radio/src/audio.cpp

radio/src/targets/common/arm/stm32/audio_dac_driver.cpp

radio/src/targets/simu/simpgmspace.cpp

radio/src/audio.cpp

raphaelcoeffic added 2 commits January 15, 2025 12:24

chore: audio drivers cleanup

8aa9b4c

chore(vs1053b): comment RIFF header

042babd

pfeerick added the house keeping 🧹 Cleanup of code and house keeping label Jan 15, 2025

refactor(xlites): moved share DSC / audio jack code into own files

4b692e4

raphaelcoeffic force-pushed the audio-cleanup branch from 202805b to 496cc46 Compare January 16, 2025 14:31

refactor(vs1053b): make most functions private

cf283da

raphaelcoeffic force-pushed the audio-cleanup branch from 496cc46 to cf283da Compare January 16, 2025 14:52

gagarinlg requested changes Jan 17, 2025

View reviewed changes

bsongis reviewed Jan 17, 2025

View reviewed changes

radio/src/audio.cpp Outdated Show resolved Hide resolved

fix: use saturated sample addition

4f4c066

raphaelcoeffic force-pushed the audio-cleanup branch from c52a03f to 4f4c066 Compare January 17, 2025 11:14

gagarinlg previously approved these changes Jan 17, 2025

View reviewed changes

fix(audio): use unsigned saturation for unsigned audio format

5f83f1e

raphaelcoeffic dismissed gagarinlg’s stale review via 5f83f1e January 17, 2025 12:12

raphaelcoeffic merged commit 5a15ffb into main Jan 17, 2025
49 checks passed

raphaelcoeffic deleted the audio-cleanup branch January 17, 2025 12:30

Provide feedback