Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change DEBUG_BAUDRATE to 460800 for TX16S & F16 #5788

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

wimalopaan
Copy link
Contributor

Using 400kB as baudrate for debugging via serial seems a bit strange because this is not a "standard baudrate" and some cheap USB/serial converter like the popular CP210x do not support these non-standard baudrates (at least with picocom).

@pfeerick
Copy link
Member

I agree... it seems strange to not be one of the "accepted" standard baud rates... but then again the TBS "standard" baudrate is 400000, so it's not unheard of ... and may be this "for reasons".

@3djc Any thoughts on this? It wasn't set to 400k due to synchronisation with something else? I've clearly forgotten what you said when I asked in passing about changing this last time! 😆

@wimalopaan
Copy link
Contributor Author

I don't see any interference with TBS since this is the DEBUG baudrate ...

@3djc
Copy link
Collaborator

3djc commented Jan 15, 2025

I don't have a strong feeling against changing it. Never heard that value been an issue for anyone, but it seems that way. But once again, may disturb people as it is used for cli too, so your working debug and cli will not work anymore after that change

@pfeerick
Copy link
Member

So maybe just change it then, and roll back if we hear (any/sufficient) complaints? Since compatibility with more USB UARTs (I've had the same issue, and while I mainly use the CH340s due to better overall capability, it was a pity not being able to use the CP210x as it was good for 1.5M baud rates) is a good thing, right?

I don't see any interference with TBS since this is the DEBUG baudrate ...

That wasn't the point there... more that there are different "standards" 🤭 As well as seeing if there was likely to be issues due to dissimilar baud rates (i.e. debugging a module running at 400000 piped through a 460800 link) or something similar.

@pfeerick pfeerick merged commit df9e313 into EdgeTX:main Jan 19, 2025
49 checks passed
@pfeerick pfeerick added the house keeping 🧹 Cleanup of code and house keeping label Jan 19, 2025
@pfeerick pfeerick added this to the 2.11 milestone Jan 19, 2025
@pfeerick pfeerick changed the title Change the DEBUG_BAUDRATE to a standard baudrate (460800) for TX16S and F16 chore: change DEBUG_BAUDRATE to 460800 for TX16S & F16 Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
house keeping 🧹 Cleanup of code and house keeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants