-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bw128): display PPM value in channel monitor #5781
Conversation
philmoz
commented
Jan 14, 2025
Great addition! constexpr coord_t CHANNEL_VALUE_OFFSET = CHANNEL_NAME_OFFSET + 43;
constexpr coord_t CHANNEL_GAUGE_OFFSET = CHANNEL_VALUE_OFFSET - 1; |
Need to rethink this. The space on the right is also used for the override and inverted indicators ('OVR' and 'INV'). |
Maybe |
Probably should be thinking about if this change really makes sense to make ... as currently the channel value column follows the PPM Units setting... (which probably needs to be renamed, but that is a different topic)... and thus allows the user the choose what is shown in most places in the UI for the channel value... -100 to 100, -100.0 to 100 or 988-2012... This change not only does not honour that configuration (i.e. why does it show both if I have configured that I want 0.0?), but also has that side effect of messing up the UI as mentioned (OVR/INV)... I just wonder if heading down this path this is going to make the UI more cluttered or confusing by adding animated elements to make up for the limited space... |
Blinking the OVR and INV states: If PPM Units is set to 'us' then the values swap sides (PPM on left, % on right). This is similar to what the color channel monitor does: |
I've updated the PR to alternate the right side view between the value, OVR and INV indicators. Also adjusted the layout to stop the percentage value overlapping the channel name when units is set to show the decimal point. Units with decimal: |
… indicator. Adjust layout to fit when units show decimal point.
5c550dd
to
fdfc9bd
Compare