Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cpn): simulator allow manually setting transmitter battery voltage #5763

Merged
merged 14 commits into from
Jan 12, 2025

Conversation

elecpower
Copy link
Collaborator

@elecpower elecpower commented Jan 6, 2025

Fixes #5053

Summary of changes:

  • add Battery Voltage option to Tools menu

Notes:

  • the radio will not update to the new voltage instantly but over a number of adc read cycles as filtered adc averaging is used.
  • there maybe instances of rounding variance as the radio uses integers
  • the tx battery settings for min max and warn values are only read on sim load ie changes via radio ui will not be detected

@elecpower elecpower added enhancement ✨ New feature or request simulator labels Jan 6, 2025
@elecpower elecpower marked this pull request as draft January 6, 2025 20:33
@pfeerick pfeerick added this to the 2.11 milestone Jan 8, 2025
@elecpower elecpower marked this pull request as ready for review January 11, 2025 00:14
@pfeerick
Copy link
Member

Thanks for this... looks great!

@pfeerick pfeerick merged commit a0da434 into main Jan 12, 2025
52 checks passed
@pfeerick pfeerick deleted the elecpower/cpn-sim-battery branch January 12, 2025 23:19
@VancouverUmbrella
Copy link

Thanks, you guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request simulator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Companion Simulator shows wrong tx battery voltage
3 participants