Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cpn): read and write to/from radio profile sd path and menu reorganisation #5753

Merged
merged 14 commits into from
Jan 24, 2025

Conversation

elecpower
Copy link
Collaborator

@elecpower elecpower commented Jan 4, 2025

Summary of changes:

  • add models and settings functions to read from and write to current radio profile SD Path. Works as Radio Read and Write but with a different root path.
  • add View menu with ability to set visibility of toolbars.
  • add Tools menu
  • rename Edit menu Models
  • rename Read/Write menu Radio
  • move menu actions to 'more' appropriate parent menus
  • housekeeping including removing redundant code, renaming and re-clustering for easier maintenance

@elecpower elecpower added enhancement ✨ New feature or request companion Related to the companion software house keeping 🧹 Cleanup of code and house keeping labels Jan 4, 2025
@pfeerick pfeerick added this to the 2.11 milestone Jan 4, 2025
@pfeerick
Copy link
Member

Yikes... you have been having fun with the menus. This is gonna take some getting used to! 🤣 But they are certainly a lot less... cluttered... Looks great! Will be great to able to be able to read/write to the local SD copy (and also then be able to sync it back to handset) without need to run Simulator standalone... making it beneficial for Mac/Linux users who can't trigger the standalone Simulator.

Is it just me being picky... or should File -> Exit not always stay at the bottom of the menu?

image

I'll just mark this draft since you've got some TODOs on the list still.

@pfeerick pfeerick marked this pull request as draft January 13, 2025 00:03
@elecpower
Copy link
Collaborator Author

Actually you found a bug. There should not be anything below Exit. Those listed are in the wrong menu. I must have undone a change

@elecpower elecpower force-pushed the elecpower/cpn-feat--read-write-sd-path branch from d5aab20 to de65825 Compare January 16, 2025 06:12
@elecpower
Copy link
Collaborator Author

@pfeerick what are your thoughts on renaming Edit menu to Models as there are other edit functions in Radio and Settings menus? The order would be File View Models Radio ...

@pfeerick
Copy link
Member

Makes sense... moving all the other menu entries around so now is the time to do it. And the otherwise "generic" cut/copy/paste operations are model specific ones here anyway.

@elecpower
Copy link
Collaborator Author

New monochrome icons created and as an interim measure copied to all other themes so the ui doesn't break. I will continue to work on the other themes and replace as available.
New functions added to toolbar.

@elecpower elecpower changed the title feat(cpn): read and write to/from radio profile sd path feat(cpn): read and write to/from radio profile sd path and menu reorganisation Jan 19, 2025
@elecpower elecpower marked this pull request as ready for review January 22, 2025 20:57
@elecpower
Copy link
Collaborator Author

@pfeerick my attempt at icons finished. I'll reach out to see if they can be polished.

@pfeerick
Copy link
Member

Looks like there could be some mixup between the toolbars selectable via the View menu and the context menu (when you right click on a toolbar)... name for one is missing, "Settings" is really the radio toolbar, and the two menus don't stay in sync with current state

image

image

Nothing else jumping out so far... looking good! :)

@elecpower
Copy link
Collaborator Author

@pfeerick who said you could use the toolbars context menu LOL. Appears fixed.

@pfeerick
Copy link
Member

pfeerick commented Jan 24, 2025

Um... I did? 🤣 Yup, that looks good now, and other than the PBKAC breaking config when syncing and making changes on that sync well, everything seems to be working great. 😍 So just cosmetics if someone wants to make the icons look better (they all look pretty good already though, and fit in with the themes well enough).

@pfeerick pfeerick merged commit 35e8b61 into main Jan 24, 2025
3 checks passed
@pfeerick pfeerick deleted the elecpower/cpn-feat--read-write-sd-path branch January 24, 2025 01:49
@elecpower
Copy link
Collaborator Author

If your satisfied with the icons we can go with those and replace separately if a polished set is prepared

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
companion Related to the companion software enhancement ✨ New feature or request house keeping 🧹 Cleanup of code and house keeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants