-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cpn): read and write to/from radio profile sd path and menu reorganisation #5753
Conversation
Yikes... you have been having fun with the menus. This is gonna take some getting used to! 🤣 But they are certainly a lot less... cluttered... Looks great! Will be great to able to be able to read/write to the local SD copy (and also then be able to sync it back to handset) without need to run Simulator standalone... making it beneficial for Mac/Linux users who can't trigger the standalone Simulator. Is it just me being picky... or should File -> Exit not always stay at the bottom of the menu? I'll just mark this draft since you've got some TODOs on the list still. |
Actually you found a bug. There should not be anything below Exit. Those listed are in the wrong menu. I must have undone a change |
d5aab20
to
de65825
Compare
@pfeerick what are your thoughts on renaming Edit menu to Models as there are other edit functions in Radio and Settings menus? The order would be File View Models Radio ... |
Makes sense... moving all the other menu entries around so now is the time to do it. And the otherwise "generic" cut/copy/paste operations are model specific ones here anyway. |
New monochrome icons created and as an interim measure copied to all other themes so the ui doesn't break. I will continue to work on the other themes and replace as available. |
@pfeerick my attempt at icons finished. I'll reach out to see if they can be polished. |
Looks like there could be some mixup between the toolbars selectable via the View menu and the context menu (when you right click on a toolbar)... name for one is missing, "Settings" is really the radio toolbar, and the two menus don't stay in sync with current state Nothing else jumping out so far... looking good! :) |
@pfeerick who said you could use the toolbars context menu LOL. Appears fixed. |
Um... I did? 🤣 Yup, that looks good now, and other than the PBKAC breaking config when syncing and making changes on that sync well, everything seems to be working great. 😍 So just cosmetics if someone wants to make the icons look better (they all look pretty good already though, and fit in with the themes well enough). |
If your satisfied with the icons we can go with those and replace separately if a polished set is prepared |
Summary of changes: