Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bw): change char selection order when editing names #5390

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Aug 6, 2024

Fixes #1858 and fixes #4618

Change the order of character selection to:

        " abcdefghijklmnopqrstuvwxyz0123456789-,."

Use long press to change case.

@pfeerick pfeerick changed the title fix(b&w): change char selection order when editing names. fix(bw): change char selection order when editing names Aug 6, 2024
@pfeerick pfeerick added the B&W Related generally to black and white LCD radios label Aug 6, 2024
@philmoz philmoz added this to the 2.11 milestone Aug 6, 2024
@pfeerick pfeerick self-requested a review August 7, 2024 10:27
@pfeerick pfeerick modified the milestones: 2.11, 2.10.x Aug 8, 2024
@pfeerick
Copy link
Member

pfeerick commented Aug 8, 2024

Have been using a 2.10 firmware with this cherry-picked with X9D+2019 for the morning for setting some stuff up... is working great.

Any reason not to have "9_-,." (underscore added)? As then (baring the last two characters swapped), this will be back to the OTX character input options and order for B&W.

@pfeerick pfeerick added the bug 🪲 Something isn't working label Aug 8, 2024
@philmoz philmoz force-pushed the philmoz/bw-edit-name branch from ca5ebd0 to 5d171b6 Compare August 8, 2024 03:44
@pfeerick pfeerick merged commit eda4e6b into main Aug 8, 2024
50 checks passed
@pfeerick pfeerick deleted the philmoz/bw-edit-name branch August 8, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B&W Related generally to black and white LCD radios bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow . (dot, period) in MT12 model names B&W alphanumeric characters in inconvenient order
2 participants