Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bw): adjust 128x64 layout to accommodate long switch names #4976

Merged
merged 2 commits into from
May 7, 2024

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented May 7, 2024

Fixes #4975

Summary of changes:

  • Adjust position of switch names to allow more room
  • Center justify switch names so it looks more balanced.

screenshot_x7_24-05-07_12-22-48
screenshot_x7_24-05-07_12-23-06

@pfeerick
Copy link
Member

pfeerick commented May 7, 2024

That looks good as it is, but if it can be right justified, can you tell me if you think that looks better (i.e. so the switch symbols would all line up regardless of if 1/2/3 letters). I tend to think it would look ... neater... but also odd 🤷

@pfeerick pfeerick added UX-UI Related to user experience (UX) or user interface (UI) behaviour B&W Related generally to black and white LCD radios labels May 7, 2024
@pfeerick pfeerick added this to the 2.10 milestone May 7, 2024
@pfeerick pfeerick changed the title fix(bw): adjust 128x64 layout to accomodate long switch names, fix(bw): adjust 128x64 layout to accommodate long switch names May 7, 2024
@philmoz
Copy link
Collaborator Author

philmoz commented May 7, 2024

With right justification the labels have to be pushed far right to allow space for long name. I think this looks cramped.
screenshot_x7_24-05-07_13-07-10
screenshot_x7_24-05-07_13-07-22

Center justification:
screenshot_x7_24-05-07_13-02-47
screenshot_x7_24-05-07_13-03-05

Edited to compensate for middle position indicator width.

Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that... agreed, center justification is indeed the better one overall.

@pfeerick pfeerick merged commit 890b0ed into EdgeTX:main May 7, 2024
44 checks passed
@philmoz philmoz deleted the bw-switch-name-layout branch July 27, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B&W Related generally to black and white LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch indicator location on b/w displays
2 participants