fix(radio): "DCL - The Game" not detecting USB joystick

[ThomasKuehne]

stop gap change to fix #4580 by reverting the USB manufacturer string to the pre-2.9.0 state ("OpenTX" instead of "EdgeTX")

[3djc]

I have already made a request for a proper PID code for EdgeTX

[ThomasKuehne]

Yes, a propper PID is the right way to go.
However I expect we have to be quite carefull - read slow - with rolling that out for the classic joystick.
Quite a few applications try to be too smart to match controllers via vendor ID, product ID and manufacturer string instead of using the HID description.
For example SDL2's SDL_CreateJoystickGUID - wich is an integral part to map axis and buttons - does that.

[pfeerick]

I hope you made a request for a range, as we need more than one as previously discussed with one of the pidcodes maintainers (for future planned changes). We will probably need to add an option to change the name for legacy applications, but there is no rush for that. Reverting to the old name works for now for apps silly enough to not honor the VID/PID alone.

…

On Sat, 17 Feb 2024, 7:56 am 3djc, ***@***.***> wrote: I have already made a request for a proper PID code for EdgeTX — Reply to this email directly, view it on GitHub <#4653 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJ66KIJ7NWNEFUBCDVES43YT7IYHAVCNFSM6AAAAABDMWDGDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBZGM4TCMJUHA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[3djc]

I have not since their request process doesn't allow range request.

[pfeerick]

For clarity, we're talking about this, correct?

pidcodes/pidcodes.github.com#929

When I emailed back in April last year about the possibility of requesting multiple PIDs, Nick suggested

It may make the most sense to reserve a block of 16 codes with the same first 24 bits.

I would interpret that as needing to create multiple folders, once for each of requested PIDs.

[3djc]

I have deleted the PR since it interferes with existing activities. Sorry wasn't aware of those

[pfeerick]

Don't be... I'm not sure of the exact PR offhand (there was a couple at the time), but this was raised when the usb joystick code was being worked on last, due to a bug in windows whereby it does not properly detect the difference between radios when they have the same VID/PID..., and the idea was proposed that there be a pool of PIDs so the user set a unique "profile number" for each radio, if using multiple radios. This also opens up the option of unique PIDs for different modes if desired.

But if it wasn't for windows being windows, this wouldn't have been an issue.

Probably should open up an issue (if there isn't one already) to outline this, so we can figure out how to actually proceed with that. 🤪

[HThuren]

... a step back ?