Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease backlight minimum for X10E on 2.9 #4540

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

packetpilot
Copy link
Contributor

If it looks familiar, it is! Same as #4539 but for the 2.9 branch.

Zero tears will be shed if this isn't something worth merging into the 2.9 branch.

I did build & flash this to my X10SE briefly, but decided running the actual 2.9.2 release w/ the same changes was a "safer" bet, so time spent was minimal, but so was the LCD backlight brightness, and zero flickers were observed. (I have a freakishly high flicker fusion threshold fwiw.)

@pfeerick
Copy link
Member

PRs that not targeting main will generally not be accepted. The development line is main, and once a PR is merged, changes cherry-picked into the maintenance branches for earlier releases if deemed necessary. However given the amount of change involved, if the main version is accepted, this will go in also. Depending on how long that decision takes will determine if it makes it for 2.9.3 or not.

@ParkerEde
Copy link
Contributor

I've tested it in 2.9.2. it works as expected

@pfeerick pfeerick added enhancement ✨ New feature or request UX-UI Related to user experience (UX) or user interface (UI) behaviour labels Jan 19, 2024
@pfeerick pfeerick added this to the 2.9.3 milestone Jan 19, 2024
@pfeerick pfeerick merged commit 0a81536 into EdgeTX:2.9 Jan 19, 2024
34 checks passed
@packetpilot packetpilot deleted the 2.9 branch January 19, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants