refactor: new GPIO HAL and StdPeriph removed #4389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b733ec3 to
a03c588
Compare
a03c588 to
e963016
Compare
…rectly chore: some additional work, still WIP chore(hal): TX16S bootloader is now working without any StdPeriph code refactor: new GPIO HAL Ported from RIOT-OS chore(noStdPeriph): fix rebase issues, get bootloader and firmware for TX16S to build, fix warnings chore(noStdPeriph): fix TX16S bootloader LCD issues chore(noStdPeriph): fix F2 compilation chore(noStdPeriph): update gpio api to allow setting the pin speed fix: make NV14/EL18/PL18/PL18EV build without StdPeriph fix: X12S compilation fix: MT12 compilation
7be21c0 to
583d002
Compare
ThomasKuehne
added a commit
to ThomasKuehne/edgetx
that referenced
this pull request
Apr 7, 2024
__CORTEX_M remains broken - potentially obsoleted by pull request EdgeTX#4389
pfeerick
reviewed
May 5, 2024
Comment on lines
-199
to
-221
| #if defined(JACK_DETECT_GPIO) && !defined(SIMU) | ||
| bool isJackPlugged() | ||
| { | ||
| // debounce | ||
| static bool debounced_state = 0; | ||
| static bool last_state = 0; | ||
|
|
||
| if (GPIO_ReadInputDataBit(JACK_DETECT_GPIO, JACK_DETECT_GPIO_PIN)) { | ||
| if (!last_state) { | ||
| debounced_state = false; | ||
| } | ||
| last_state = false; | ||
| } | ||
| else { | ||
| if (last_state) { | ||
| debounced_state = true; | ||
| } | ||
| last_state = true; | ||
| } | ||
| return debounced_state; | ||
| } | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Was about to rebase this rather than bother you since it looks straightforward... but, um... did you remove this by accident? As isJackPlugged() is still used in code...
|
Closed in favour of #5023 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
This PR removed the StdPeriph libraries
all code has been converted to STM32 HAL