Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nv14/el18): Add help popup showing mapping when using hats as keys. #4359

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Nov 25, 2023

For when I forget what the key assignments are :)

screenshot_el18_23-11-25_09-39-08

@rotorman
Copy link
Member

I wonder if graphical representation might be more intuitive for the user. Due to portrait display, showing the trims in two rows is less perfect though. Here two images I created for further discussion:

Left trim hat:
NV14_buttons_left

Right trim hat:
NV14_buttons_right

@pfeerick
Copy link
Member

I have no preference either way, but appreciate the reminder as to what the heck the stick mapping actually is 🤣 . The caveat with doing it as an image is it can't be translated, so instead you would need to use the image of the hats and overlay text on it. Showing the hats one after the other is perfectly fine since there is a Left and Right heading.

@richardclli
Copy link
Collaborator

Another radio that may use HAT mode is PL18 series, need to consider this as well.

@rotorman
Copy link
Member

In order to be able to also use this feature on radios that do not have hat type trims (e.g. PL18/Paladin EV), a suggestion to use "trim-navigation" instead of "hats mode" to keep it more generic.

@pfeerick
Copy link
Member

Just gonna leave this as it is for now, to be tweaked in 2.11 if needed/desired.

@pfeerick pfeerick added color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour labels Dec 12, 2023
@pfeerick pfeerick added this to the 2.10 milestone Dec 12, 2023
@pfeerick pfeerick merged commit e4dd546 into EdgeTX:main Dec 12, 2023
37 checks passed
ulfhedlund added a commit to ulfhedlund/edgetx that referenced this pull request Dec 12, 2023
ulfhedlund added a commit to ulfhedlund/edgetx that referenced this pull request Dec 12, 2023
pfeerick pushed a commit to ulfhedlund/edgetx that referenced this pull request Dec 12, 2023
pfeerick pushed a commit to ulfhedlund/edgetx that referenced this pull request Dec 12, 2023
@philmoz philmoz deleted the hats-as-keys-help branch February 26, 2024 09:53
@pfeerick pfeerick mentioned this pull request Mar 11, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants