-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(mixer): improve delays #4256
Conversation
Looks ok to me. I was looking at this yesterday and your solution is almost exactly the same as what I came up with. One thing, not directly related to this issue, is that the 'stickIndex' variable is redundant. |
@pfeerick we should probably mention this in the release notes. Just in case someone had set something in the delays that was ineffective then, but would be now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I think time to rework fully the mixer is closing, no matter how scary
Only with unit tests with close to 100% code coverage |
Can't see anything broken here... only fixed 😁 Servo auto test delay/slow mixer, and various switch-based slow/delay with FM conditionals working as expected. |
This PR removes the distinction between following with respect to how delays are handled:
Fixes #4254