Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(color): Cleanup layout refresh logic. #4074

Merged
merged 1 commit into from
Oct 30, 2023
Merged

chore(color): Cleanup layout refresh logic. #4074

merged 1 commit into from
Oct 30, 2023

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Sep 20, 2023

Summary of changes:

  • Remove top bar forced refresh of widgets, let widgets decide if refresh is needed (while retaining 100ms refresh interval)
  • Adjust main view layout when options are changed instead of checking options repeatedly in the checkEvents function
  • Adjust date time widget to only refresh when value changes

@pfeerick pfeerick added enhancement ✨ New feature or request color Related generally to color LCD radios labels Sep 21, 2023
@pfeerick pfeerick added this to the 2.10 milestone Sep 21, 2023
@pfeerick pfeerick self-requested a review October 13, 2023 10:46
@pfeerick pfeerick merged commit 374c782 into EdgeTX:main Oct 30, 2023
@philmoz philmoz deleted the layout-refresh branch February 3, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphaelcoeffic raphaelcoeffic raphaelcoeffic approved these changes

@pfeerick pfeerick Awaiting requested review from pfeerick

Assignees
No one assigned
Labels
color Related generally to color LCD radios enhancement ✨ New feature or request
Projects
None yet
Milestone
2.10
Development

Successfully merging this pull request may close these issues.
3 participants
@philmoz @raphaelcoeffic @pfeerick