fix(color): Change behaviour of TELE button on widget setup page to work like RTN button. #3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… button. Prevents recursive loading of widget setup page.
|
Should the SYS and MDL buttons be blocked on the widget setup page? |
|
IMO, Yes, once you are in the widget setup screen only the roller/ENT and
touch are valid inputs to be responded to. i.e. SYS/MDL/TELE/PGUP/PGDN
should be ignored. How you have TELE should be fine though... it sort of
makes sense that it could be perceived as a toggle for the widget setup
screen.
…On Mon, Jul 24, 2023 at 2:16 PM philmoz ***@***.***> wrote:
Should the SYS and MDL buttons be blocked on the widget setup page?
Currently they are handled by the main view so open the RADIO/MODEL menu
pages.
—
Reply to this email directly, view it on GitHub
<#3845 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJ66KMQ4WFMQPYVPVGPRE3XRXZJRANCNFSM6AAAAAA2UHMZI4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
pfeerick
pushed a commit
that referenced
this pull request
Jul 28, 2023
#3845) * Change behaviour of TELE button on widget setup page to work like RTN button. Prevents recursive loading of widget setup page. * Ignore SYS & MDL buttons on widget setup page.
pfeerick
pushed a commit
that referenced
this pull request
Jul 28, 2023
#3845) * Change behaviour of TELE button on widget setup page to work like RTN button. Prevents recursive loading of widget setup page. * Ignore SYS & MDL buttons on widget setup page.
|
Buenas tardes, actualizo a 2.8.5 en TX16S y deja de funcionar la pantalla tactil. Gracias |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents recursive loading of widget setup page.
Fixes #3842