Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AFHDS3): V0 ibus option and failsafe malfunction #3793

Merged
merged 2 commits into from
Aug 3, 2023
Merged

fix(AFHDS3): V0 ibus option and failsafe malfunction #3793

merged 2 commits into from
Aug 3, 2023

Conversation

richardclli
Copy link
Collaborator

Fixes #3791
Fixes #3792

Summary of changes:

@richardclli richardclli self-assigned this Jul 12, 2023
@richardclli richardclli added this to the 2.9 milestone Jul 12, 2023
raphaelcoeffic
raphaelcoeffic reviewed Jul 12, 2023
View reviewed changes
radio/src/pulses/afhds3.cpp Show resolved Hide resolved
radio/src/pulses/afhds3_config.h Outdated Show resolved Hide resolved
@richardclli richardclli changed the title Fixed failsafe function and sync output of V0 version fix(AFHDS3): V0 ibus option and failsafe malfunction Jul 12, 2023
@richardclli
Copy link
Collaborator Author

richardclli commented Jul 25, 2023 •
edited
Loading

@pfeerick I think this is good for merge, for now. There are some historical problem about V0 receivers and need more time for Flysky to resolve in their TX firmware first.

@pfeerick
Copy link
Member

Sounds good to me... if there are no further concerns from @raphaelcoeffic @gagarinlg I'll review and try this shortly.

@pfeerick pfeerick self-requested a review July 26, 2023 01:13
pfeerick
pfeerick approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on FTr12B w/ EL18, both iBUS IN and failsafe settings now runtime configurable rather than bind time (or perhaps not at all in some instances).

@pfeerick pfeerick added the bug 🪲 Something isn't working label Aug 3, 2023
@pfeerick pfeerick merged commit c6503a7 into main Aug 3, 2023
@pfeerick pfeerick deleted the fix-3791-ibus_in branch August 3, 2023 04:15
@philmoz
Copy link
Collaborator

philmoz commented Aug 4, 2023

I think line 924 is wrong (compiler complains).

      cfg->others.ExternalBusType == EB_BT_IBUS1_OUT;

should probably be assignment not comparison.

      cfg->others.ExternalBusType = EB_BT_IBUS1_OUT;

richardclli added a commit to richardclli/edgetx that referenced this pull request Aug 4, 2023
@richardclli
fix(AFHDS3): iBus IN and Failsafe settings not updating (EdgeTX#3793)
9078421 
* Fixed failsafe function and sync output of V0 version

* Make the code more readable.

Co-authored-by: Xy201207 <yaoxu@flysky.com>
@pfeerick
Copy link
Member

pfeerick commented Aug 4, 2023 •
edited
Loading

@richardclli I haven't pushed the commit for this on the 2.9 branch yet, so can make that change before pushing it if that is the only change required

edit: ouch... managed to misattribute another commit to this PR ... bad VSCode!

pfeerick pushed a commit that referenced this pull request Aug 4, 2023
@richardclli @pfeerick
fix(AFHDS3): iBus IN and Failsafe settings not updating (#3793)
e6ec31b 
* Fixed failsafe function and sync output of V0 version

* Make the code more readable.

Co-authored-by: Xy201207 <yaoxu@flysky.com>
pfeerick added a commit that referenced this pull request Aug 4, 2023
@pfeerick
Revert "fix(AFHDS3): iBus IN and Failsafe settings not updating (#3793)"
ef6891f 
This reverts commit e6ec31b.
@richardclli
Copy link
Collaborator Author

@richardclli I haven't pushed the commit for this on the 2.9 branch yet, so can make that change before pushing it if that is the only change required

edit: ouch... managed to misattribute another commit to this PR ... bad VSCode!

Yes, that is the only change needed.

pfeerick added a commit that referenced this pull request Aug 4, 2023
@pfeerick
fix(AFHDS3): iBus IN and Failsafe settings not updating (#3793)
7e29fc7
pfeerick added a commit that referenced this pull request Aug 4, 2023
@pfeerick
fix(AFHDS3): Typo from #3793
f110bda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagarinlg gagarinlg gagarinlg left review comments

@raphaelcoeffic raphaelcoeffic raphaelcoeffic left review comments

@pfeerick pfeerick pfeerick approved these changes

Assignees

@richardclli richardclli

Labels
bug 🪲 Something isn't working
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.

AFHDS3: Failsafe broken AFHDS3: FGr4P receiver cannot setup iBUS IN
5 participants
@richardclli @pfeerick @philmoz @raphaelcoeffic @gagarinlg