Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Comment out the top two trace flooding calls #3767

Merged
merged 1 commit into from
Jul 6, 2023
Merged

chore: Comment out the top two trace flooding calls #3767

merged 1 commit into from
Jul 6, 2023

Conversation

mha1
Copy link
Contributor

@mha1 mha1 commented Jul 5, 2023

Fixes: having do comment out those TRACE() calls every time you start debugging using traces

Summary of changes:

  • commented out misleading TRACE() call for bad alignment if writing stack allocated buffers to SD card
  • commented out trace flooding TRACE() call in lcd driver

If it was Xmas I'd wish for this to be in 2.9 too.

@mha1 mha1 changed the title chore, debug mode: comment out top the two trace flooding and misleading TRACE() calls chore, debug mode: comment out the top two trace flooding and misleading TRACE() calls Jul 5, 2023
@pfeerick pfeerick added the compilation Related to compiling the firmware and firmware options label Jul 6, 2023
@pfeerick pfeerick added this to the 2.9 milestone Jul 6, 2023
@pfeerick pfeerick changed the title chore, debug mode: comment out the top two trace flooding and misleading TRACE() calls chore: Comment out the top two trace flooding calls Jul 6, 2023
@pfeerick pfeerick merged commit ab5f44b into EdgeTX:main Jul 6, 2023
@mha1 mha1 deleted the Disable_annoying_traces-relevant-for-debug-mode-only branch July 6, 2023 01:35
pfeerick pushed a commit to mha1/edgetx that referenced this pull request Jul 7, 2023
@mha1 @pfeerick
chore: Comment out the top two trace flooding calls (EdgeTX#3767)
bf965b1 
- only relevant in debug mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
compilation Related to compiling the firmware and firmware options
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.
2 participants
@mha1 @pfeerick