Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cpn): warn if radio settings version not supported #3766

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

elecpower
Copy link
Collaborator

@elecpower elecpower commented Jul 5, 2023

Summary of changes:

  • compare radio.yml semver to Companion version
  • warn user that proceeding may result in corrupted radio and/or model settings

Related to but DOES NOT resolve
#3758

The purpose of this PR is to link to the commits that can be cherry picked into 2.8.5 and 2.9 RC and merged into main.

@elecpower elecpower added enhancement ✨ New feature or request companion Related to the companion software labels Jul 5, 2023
@pfeerick pfeerick added this to the 2.8.5 milestone Jul 19, 2023
@pfeerick pfeerick merged commit 40d48e9 into main Jul 19, 2023
@pfeerick pfeerick deleted the elecpower/cpn-yaml-semver-checking branch July 19, 2023 01:23
pfeerick pushed a commit that referenced this pull request Jul 19, 2023
* Add semver checking to radio.yml

* Rename radio settings variable to allow comparison to model settings version
pfeerick pushed a commit that referenced this pull request Jul 22, 2023
* Add semver checking to radio.yml

* Rename radio settings variable to allow comparison to model settings version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
companion Related to the companion software enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants