Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bw): Change layout of telemetry page on B&W radios to match color layout. #3761

Closed
wants to merge 2 commits into from

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Jul 5, 2023

As suggested on RC Video Reviews video on 2.9 RC1 for B&W radios.

Moves the RSSI alarms section to below the sensors section.

@pfeerick
Copy link
Member

pfeerick commented Jul 5, 2023

Something more is needed for both implementations... try scrolling up and down the page so it wraps around (or more simply, just scroll back one line so it wraps around, and then forwards so you should be at the top again), and the sensors heading will now be missing. When it was RSSI before it didn't disappear. But sleeps calls.... 🛌

@pfeerick pfeerick added the B&W Related generally to black and white LCD radios label Jul 5, 2023
@pfeerick pfeerick added this to the 2.9 milestone Jul 5, 2023
@philmoz
Copy link
Collaborator Author

philmoz commented Jul 5, 2023

Something more is needed for both implementations... try scrolling up and down the page so it wraps around (or more simply, just scroll back one line so it wraps around, and then forwards so you should be at the top again), and the sensors heading will now be missing. When it was RSSI before it didn't disappear. But sleeps calls.... 🛌

This only happens if the first sensor in the list is empty.

@philmoz philmoz changed the title feat(B&W) - Change layout of telemetry page on B&W radios to match color layout. feat(B&W): Change layout of telemetry page on B&W radios to match color layout. Jul 5, 2023
@pfeerick
Copy link
Member

pfeerick commented Jul 6, 2023

ok, I can see that k never returns to 0 on the wraparound, hence ITEM_TELEMETRY_SENSORS_LABEL isn't displayed again. This just feels broken if you can lose a line simply by scrolling, regardless of whether sensors are present are not. It would be nice if that can be fixed, but there is no denying this is an improvement given the RSSI / link quality settings are really only looked at a few and then forgotten.

@philmoz
Copy link
Collaborator Author

philmoz commented Jul 6, 2023

I've looked at the (complex) menu navigation code and I'm not sure this is easily fixable without risking breaking other stuff.

Maybe something for a separate PR.

@pfeerick
Copy link
Member

pfeerick commented Jul 6, 2023

I'll give @3djc a chance to have a look that this and if there's no easy workaround, yes, definitely leave it for a separate PR.

@pfeerick pfeerick changed the title feat(B&W): Change layout of telemetry page on B&W radios to match color layout. feat(bw): Change layout of telemetry page on B&W radios to match color layout. Jul 6, 2023
@philmoz philmoz closed this Jul 6, 2023
@philmoz
Copy link
Collaborator Author

philmoz commented Jul 6, 2023

Superseded by #3770

@philmoz philmoz deleted the bw-telemetry-layout branch October 23, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B&W Related generally to black and white LCD radios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants