Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add X7S BT detection #3754

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Add X7S BT detection #3754

merged 3 commits into from
Jul 12, 2023

Conversation

3djc
Copy link
Collaborator

@3djc 3djc commented Jul 3, 2023

This fixes #3752

@3djc 3djc added the bug/regression ↩️ A new version of EdgeTX broke something label Jul 3, 2023
@philmoz
Copy link
Collaborator

philmoz commented Jul 4, 2023

Should we delete the redundant function BT_USART_IRQHandler in bluetooth_driver.cpp as part of this PR?

@pfeerick pfeerick requested a review from raphaelcoeffic July 4, 2023 01:04
@raphaelcoeffic
Copy link
Member

Gents, feel free to delete that _OBSOLETE code, no problem with me :-) And if it works, just merge it!

@pfeerick pfeerick added this to the 2.9 milestone Jul 12, 2023
@pfeerick pfeerick merged commit efd580e into main Jul 12, 2023
@ParkerEde
Copy link
Contributor

Is it possible that this PR is not yet included in the 2.9 branch? Or do I just have tomatoes in my eyes? ;-)

@raphaelcoeffic
Copy link
Member

Is it possible that this PR is not yet included in the 2.9 branch? Or do I just have tomatoes in my eyes? ;-)

Either way: it's been merged 3 days ago, so that it should be in today's nightly build.

@ParkerEde
Copy link
Contributor

Yes, that is correct. I saw that too. However, I am specifically interested in branch 2.9, as I would like to test it extensively with all the PRs that have already been merged.

@raphaelcoeffic
Copy link
Member

However, I am specifically interested in branch 2.9, as I would like to test it extensively with all the PRs that have already been merged.

I don't think this has been cherry-picked to 2.9, indeed. The question is whether or not this is necessary.

@3djc
Copy link
Collaborator Author

3djc commented Jul 15, 2023

I think it should, there is no other way for X7S users to get working BT

@ParkerEde
Copy link
Contributor

This PR is assigned to milestone 2.9. Now it is only about the merge into the 2.9 branch.

@pfeerick
Copy link
Member

I'm on a different device atm, but it has probably been cherry-picked, just not pushed.

@pfeerick pfeerick deleted the 3djc/fix-x7s-bt-detection branch July 16, 2023 04:39
pfeerick pushed a commit that referenced this pull request Jul 19, 2023
@3djc @pfeerick
fix: X7S BT detection (#3754)
f942761 
* Add X7S BT detection

* Compile fix

* chore: remove obsolte section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphaelcoeffic raphaelcoeffic Awaiting requested review from raphaelcoeffic

Assignees
No one assigned
Labels
bug/regression ↩️ A new version of EdgeTX broke something
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.

Bluetooth Settings missing in Hardware menu for Taranis QX7S
5 participants
@3djc @philmoz @raphaelcoeffic @ParkerEde @pfeerick