Feature: SF Audio amplifier mute - 2.9 edition

[mha1]

This PR adds "Audio amplifier mute" to the SF/GF list. Possible use cases:

• total silence, no noise, not only volume down
• home brew BT Audio module picking up the audio signal at the amplifier input to use wireless ear buds. Silencing the speakers is necessary. Using SF makes that easy

[Eldenroot]

CZ:
#define TR_SF_DISABLE_AUDIO_AMP "Vypnutí zesilovače zvuku"

ENG original text:
#define TR_SF_DISABLE_AUDIO_AMP "Audio Amp Off"

• @zyren CN / TW
• @Eldenroot CZ
• @HThuren DA
• @ParkerEde / @TheIsotopes DE
• @Pat6874 FR
• @offer-shmuely HE
• @robustini IT
• @ToshihiroMakuuchi JP
• @ulfhedlund SE
• @ajjjjjjjj PL

[HThuren]

DA
#define TR_SF_DISABLE_AUDIO_AMP TR("Sluk audio amp", "Sluk audio amplifier")

[Pat6874]

#define TR_SF_DISABLE_AUDIO_AMP "Audio Amp Off" FR "Désact. Ampli Audio" Le 2 juil. 2023, 11:59, à 11:59, Eldenroot ***@***.***> a écrit:

…

CZ: `#define TR_SF_DISABLE_AUDIO_AMP "Vypnutí zesilovače zvuku"` ENG original text: `#define TR_SF_DISABLE_AUDIO_AMP "Audio Amp Off"` @zyren CN / TW @Eldenroot CZ @HThuren DA @ParkerEde / @TheIsotopes DE @Pat6874 FR @offer-shmuely HE robustini IT @ToshihiroMakuuchi JP @ulfhedlund SE @ajjjjjjjj PL -- Reply to this email directly or view it on GitHub: #3741 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>

[mha1]

I have been transaulted :-)

@elecpower: Companion done, I'd appreciate your review

• updated companion for new SF
• updated radio languages CZ, DA, FR
• updated companion languages CZ, DA, FR

[robustini]

IT
#define TR_SF_DISABLE_AUDIO_AMP TR("Amp. audio off", "Amplificatore audio off")

[ParkerEde]

DE
#define TR_SF_DISABLE_AUDIO_AMP "Audio Amp AUS"

[raphaelcoeffic]

@mha1 has this already been implemented in main? Normally we implement new things in main, and back-port / cherry-pick if really necessary into a stable branch (ex: 2.9), not the opposite.

[zyren]

CN

#define TR_SF_DISABLE_AUDIO_AMP        "关闭音频功放"

TW

#define TR_SF_DISABLE_AUDIO_AMP        "關閉音頻功放"

[mha1]

@raphaelcoeffic I know, but main was in flux and changing yaml datastructs logic. Find PR ported to main here: #3753

[pfeerick]

The other thing you should have kept in mind is 2.9 has been essentially in feature freeze, and is now in RC, so basing this on 2.9 is more than a bit naughty ;)

[mha1]

what? why? me naughty? I plead total ignorance your honor.

[ajjjjjjjj]

PL

#define TR_SF_DISABLE_AUDIO_AMP TR("Wycisz wzm.", "Wycisz wzmacniacz audio")

[mha1]

@pfeerick Seriously, say the word and I'll close it. Until then I'll keep it alive and updated.

[ulfhedlund]

SE
#define TR_SF_DISABLE_AUDIO_AMP TR("Audioförst. av","Audioförstärkare av")

[pfeerick]

@pfeerick Seriously, say the word and I'll close it. Until then I'll keep it alive and updated.

Nah, keep it alive... I'm inclined to let this infraction slide 🤪. Might as well round that feature off a bit more since you've already done the 2.9 version.

[pfeerick]

btw, I think you should be able to knock the type="unfinished" flag off the companion translations that are translated ;)

[mha1]

I accept the sentence as hard as it may be, your Honor

[ToshihiroMakuuchi]

JP
#define TR_SF_DISABLE_AUDIO_AMP "オーディオアンプ OFF"

[brainbubblersbest]

sorry. But why not for the X12S?

FROS mutes the Audio Ampflifier too when using external r9m to prevent the humming noise.
So it does exactly the same on fros as the other radios that are supported here on Edgetx.

MCU PI09 can be changed to Audio_Mute_pin in hal instead of the actual definition Shutdown_Pin.
MCU PI09 is traced to The Amplifier Shutdown Pin like it is on the T16. And I think it is not used under the actual hal Definition somewhere in the code.

Here is the circuit documentation from the T16.
https://user-images.githubusercontent.com/48190425/102207842-ed477380-3ece-11eb-936c-3139c995007c.jpg
Similar to x12s

[mha1]

@3djc your word on this?

[3djc]

To my knowledge, fros uses the x12s audio chip in a completely different way that allows them to mute, but would not work at all with EdgeTx (and the audio chip mute pin is soldered to the ground)

[mha1]

🙏

[brainbubblersbest]

To my knowledge, fros uses the x12s audio chip in a completely different way that allows them to mute, but would not work at all with EdgeTx (and the audio chip mute pin is soldered to the ground)

Yes it is soldered to Ground.
And Yes FROS uses a second Chip for mp3 decoding. (VLS1)
Both Audio ICs together with mcu
But that Chip was never used at all with opentx and edgetx.
The Shutdown Pin from apa2603a is traced in the same way like the fm8002 SD Pin on T16 Mainboard.

Im sure about that. Thats why I desoldered my defective old Mainboard and measured the Layout to compare with T16/X10 Tech Documentation.
THIS mainboard

The X10 Hal definition may be Named audio mute pin. But if you would measure the pcb, you would notice that it in fact controls the Shutdown Pin on the audio Amplifier. NOT the Mute In pin.
Fm8002 doesnt even have such an Input

Just take a closer Look into THIS:
T16_X10Copy Wiring Diagramm

Anyway: I would definite Test this on my Radio for Validation. 😉

[3djc]

If you are talking about PI.09, then I suggest you read this : https://github.com/opentx/opentx/blob/00d3d62f6a5acacc35e2c3f71608bd7ae06a839c/radio/src/targets/horus/audio_spi_driver.cpp#L362

[brainbubblersbest]

Thats interesting and weird. The datasheet describes startup time on that IC with 1,6us. Thank you for that explanation. Im still available for testing if you will give it a try. But u have a good Argument against stuff in this direction. 😕 3djc ***@***.***> schrieb am Di., 22. Aug. 2023, 22:03:

…

If you are talking about PI.09, then I suggest you read this : https://github.com/opentx/opentx/blob/00d3d62f6a5acacc35e2c3f71608bd7ae06a839c/radio/src/targets/horus/audio_spi_driver.cpp#L362 — Reply to this email directly, view it on GitHub <#3741 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALPVHWOYUZBSXOO2OUGTZWTXWUGA5ANCNFSM6AAAAAAZ25XSRY> . You are receiving this because you commented.Message ID: ***@***.***>

[raphaelcoeffic]

@brainbubblersbest the real question is whether or not the MUTE pin (marked blue in your picture) is somehow wired to other things as well like shutdown. Regarding start-up time, it is specified in the datasheet as 1.2s (up to 2s):

That being said, if you guys want to reverse engineer how it is used in FrOS, go ahead! We can see how that can be implemented then.

That being said, the X12S audio circuit is fairly noise-free, so that it can be implemented in a different way, for instance by stopping data transfer to the VS1053b (maybe just dropping the buffers that would otherwise be transferred instead).

[3djc]

@brainbubblersbest the real question is whether or not the MUTE pin (marked blue in your picture) is somehow wired to other things as well like shutdown.

Mute is connected to GND directly