-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(radio) - Include internal module type in backup data for EM so radio re-connects to receiver. #3603
Conversation
... so radio re-connects to receiver if internal module is in use!
Is this fix also applied in version 2.10.0-rc3? - Horus X10 Express. Just experienced a 'recovery mode' situation where control to the airplane was lost. |
yes it is included in 2.10-x |
Oops. Any root cause analysis available like a log or anything I could look at cos this is scary. In this case though no damage, the plane was very light and floated down in failsafe mode however, I also fly jets... |
And also latest 2.8.x and 2.9.x IIRC. Unfortunately no longs or anything...
This isn't a computer or phone level of hardware... Just a "simple"
microcontroller asked to do a *lot* of things. If the radio EM'd and didn't
reconnect to the RX when using internal RF, that is not good though. Keep
in mind only primary controls will be active - no Lua/Widgets, and possibly
LS/SF will not be active - although that should not effect whether the RF
link is re-established or not.
…On Fri, 26 Apr 2024, 6:53 am BompaBert, ***@***.***> wrote:
Oops. Any root cause analysis available like a log or anything I could
look at cos this is scary. In this case though no damage, the plane was
very light and floated down in failsafe mode however, I also fly jets...
—
Reply to this email directly, view it on GitHub
<#3603 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJ66KOCYNCHNBFP3LP4T2DY7FUMBAVCNFSM6AAAAAAYEKGRVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZYGE2TMNJZGI>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Yea, I had no control over the plane at all. It showed failsafe behavior when the radio went in EM - motor cutoff etc, stab auto level engaged etc... |
It can take up to a few seconds because the CPU resets. Hence the radio firmware including the RF link reboots. Despite taking some shortcuts here and there (eg no pre-start checks, no GUI) it'll take some time until the RF link is re-established. The receiver will f/s until then. |
In my case, the Horus X10 needed a power off/on to get rid of the recovery mode screen and to regain control over the airplane. |
EM is not a silver bullet. If the CPU hard fault persists nothing can be done. It you can do debug builds you can test if the general EM process to boot into a limp home mode after a hard fault works. Follow this: #3599 (comment) |
In my case, the Horus X10 needed a power off/on to get rid of the
recovery mode screen
That part is expected
needed a power off/on to regain control over the airplane.
That is what we are trying to prevent, but it is not guaranteed
unfortunately. How long of a delay between you realising it was in EM and
power cycling? As it will take a few seconds for it to reboot and for the
RF link to re-establish (if it is going to). And are any lua scripts,
logical switches, special functions, etc, required in order for you to have
control?
…On Sat, Apr 27, 2024 at 1:18 AM Michael ***@***.***> wrote:
EM is not a silver bullet. If the CPU hard fault persists nothing can be
done.
It you can do debug builds you can test if the general EM process to boot
into a limp home mode after a hard fault works. Follow this: #3599
(comment)
<#3599 (comment)>
—
Reply to this email directly, view it on GitHub
<#3603 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJ66KPT3LBFXVZCS6KPOLDY7JV5LAVCNFSM6AAAAAAYEKGRVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZZGYYDANRXGQ>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Control was lost when the plane was about 70 yards away from me. First time I saw that the radio was in recovery mode was when I got back to the pits after recovering the plane - maybe 5 minutes or so. I do use logical and functions switches managing motor and stabilization see attached .yml file. |
If this might help. Radio went into recovery mode again today. This time it happened when I was scrolling to my models list to select another model to fly with. Power off/on got me out and I flew with no issues the rest of the time. I do not believe the EM is related to the SD card as after the first EM, the card was replaced (8G SanDisk Industrial MLC MicroSD SDHC UHS-I Class 10). |
Please raise an issue on this. |
For reference, I just (purposefully) tested EM on a TX16S with 2.10RC3 and a ELRS link. Upon triggering EM, i regained control of the receiver within 3 seconds, so if an issue exist, it is more radio specific than systemic |
Yes, I did it a while ago with MPM/HoTT and ELRS. Both regained control within a few seconds. It just takes quite a while for the modules to boot. And as I said EM is not a silver bullet but a best effort attempting to regain control. If you can regain control depends on the type of fault that caused the EM. |
FYI, a few days ago issue #4940 was opened. Looks very similar to this one but for a TX16. |
Absolutely not. This is not about what can create an EM (albeit we are working hard to try to reduce those occurrences), but what happens when it happens (because it can happen also without software been causing it) |
The only similarity is that a EM occurred. Unless you are poking around in the SD card files, and looking at images while in flight, that is where the resemblance ends. 🤪 Also, it seems like that issue was resolved for the user in 2.10.0-rc3 (had been running 2.9.4 when it occurred), whereas you are seeing an issue on 2.10.0-rc3. For your particular situation, what we really need to know is whether the RF link is re-established on EM, to verify it is working consistently across all targets, or if some other factor could have been responsible for not regaining controls. |
Just to be clear. I had 2 different situations when non recoverable EM occurred. Once during flight and once by trying to select a model after scrolling through them. I opened the issue on the second occurrence. Sent from my iPhone.
|
FYI, moved back to 2.9.4 - what a pain in the butt - partly caused by the changes in the radio profile between both versions - see attachment. Needed to review and adjust each of my models as the pots and sliders disappeared from each file - all special instructions 'play track or value' duration parameters went to 1sec as well. |
You should never go to previous major version with the new radio and models files. This is why it is recommended to save your sd before upgrading |
10/4. Just, I had several major changes in between... All good now. Will keep you guys posted. |
FYI. Two more EM's past week on the same day. Version 2.10-2. One in flight - recovery successful. The other EM occurred while changing from model A to model B. This happened twice and so far only when using the 9 icons per page. No EM using the 4 models per page. Also after pwr off/on, model A is still active. Removed all widgets except Battcheck and Modelname. Under tools, I have only Frsky receiver scripts, the sensor_config and model locator script. Will keep you updated. |
Fixes #3599