Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio) - Include internal module type in backup data for EM so radio re-connects to receiver. #3603

Merged
merged 1 commit into from
May 17, 2023

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented May 16, 2023

Fixes #3599

@pfeerick pfeerick added the bug 🪲 Something isn't working label May 17, 2023
@pfeerick pfeerick added this to the 2.8.5 milestone May 17, 2023
@pfeerick pfeerick merged commit 75ccc4a into EdgeTX:main May 17, 2023
@mha1 mha1 mentioned this pull request May 24, 2023
1 task
pfeerick pushed a commit that referenced this pull request Jul 4, 2023
... so radio re-connects to receiver if internal module is in use!
@philmoz philmoz deleted the fix-EM-connect branch October 23, 2023 22:35
@BompaBert
Copy link

Is this fix also applied in version 2.10.0-rc3? - Horus X10 Express. Just experienced a 'recovery mode' situation where control to the airplane was lost.

@3djc
Copy link
Collaborator

3djc commented Apr 25, 2024

yes it is included in 2.10-x

@BompaBert
Copy link

Oops. Any root cause analysis available like a log or anything I could look at cos this is scary. In this case though no damage, the plane was very light and floated down in failsafe mode however, I also fly jets...

@pfeerick
Copy link
Member

pfeerick commented Apr 25, 2024 via email

@BompaBert
Copy link

Yea, I had no control over the plane at all. It showed failsafe behavior when the radio went in EM - motor cutoff etc, stab auto level engaged etc...

@mha1
Copy link
Contributor

mha1 commented Apr 26, 2024

It can take up to a few seconds because the CPU resets. Hence the radio firmware including the RF link reboots. Despite taking some shortcuts here and there (eg no pre-start checks, no GUI) it'll take some time until the RF link is re-established. The receiver will f/s until then.

@BompaBert
Copy link

In my case, the Horus X10 needed a power off/on to get rid of the recovery mode screen and to regain control over the airplane.

@mha1
Copy link
Contributor

mha1 commented Apr 26, 2024

EM is not a silver bullet. If the CPU hard fault persists nothing can be done.

It you can do debug builds you can test if the general EM process to boot into a limp home mode after a hard fault works. Follow this: #3599 (comment)

@pfeerick
Copy link
Member

pfeerick commented Apr 27, 2024 via email

@BompaBert
Copy link

Control was lost when the plane was about 70 yards away from me. First time I saw that the radio was in recovery mode was when I got back to the pits after recovering the plane - maybe 5 minutes or so. I do use logical and functions switches managing motor and stabilization see attached .yml file.
MXS2.zip
@mha1 , love to help out but am not familiar with debug builds - no clue how to run the suggested test.

@BompaBert
Copy link

If this might help. Radio went into recovery mode again today. This time it happened when I was scrolling to my models list to select another model to fly with. Power off/on got me out and I flew with no issues the rest of the time. I do not believe the EM is related to the SD card as after the first EM, the card was replaced (8G SanDisk Industrial MLC MicroSD SDHC UHS-I Class 10).
I can go back to version 2.9 and see ( I had no EM's then)- advise here is welcome. Last I want to do is go back to OTX :-(

@mha1
Copy link
Contributor

mha1 commented May 2, 2024

Please raise an issue on this.

@3djc
Copy link
Collaborator

3djc commented May 2, 2024

For reference, I just (purposefully) tested EM on a TX16S with 2.10RC3 and a ELRS link. Upon triggering EM, i regained control of the receiver within 3 seconds, so if an issue exist, it is more radio specific than systemic

@mha1
Copy link
Contributor

mha1 commented May 2, 2024

Yes, I did it a while ago with MPM/HoTT and ELRS. Both regained control within a few seconds. It just takes quite a while for the modules to boot.

And as I said EM is not a silver bullet but a best effort attempting to regain control. If you can regain control depends on the type of fault that caused the EM.

@BompaBert
Copy link

FYI, a few days ago issue #4940 was opened. Looks very similar to this one but for a TX16.

@3djc
Copy link
Collaborator

3djc commented May 2, 2024

Absolutely not. This is not about what can create an EM (albeit we are working hard to try to reduce those occurrences), but what happens when it happens (because it can happen also without software been causing it)

@pfeerick
Copy link
Member

pfeerick commented May 2, 2024

FYI, a few days ago issue #4940 was opened. Looks very similar to this one but for a TX16.

The only similarity is that a EM occurred. Unless you are poking around in the SD card files, and looking at images while in flight, that is where the resemblance ends. 🤪 Also, it seems like that issue was resolved for the user in 2.10.0-rc3 (had been running 2.9.4 when it occurred), whereas you are seeing an issue on 2.10.0-rc3. For your particular situation, what we really need to know is whether the RF link is re-established on EM, to verify it is working consistently across all targets, or if some other factor could have been responsible for not regaining controls.

@BompaBert
Copy link

BompaBert commented May 2, 2024 via email

@BompaBert
Copy link

FYI, moved back to 2.9.4 - what a pain in the butt - partly caused by the changes in the radio profile between both versions - see attachment. Needed to review and adjust each of my models as the pots and sliders disappeared from each file - all special instructions 'play track or value' duration parameters went to 1sec as well.
I'll keep you informed on any EM occurrences.
ETX prof diff.zip

@3djc
Copy link
Collaborator

3djc commented May 3, 2024

You should never go to previous major version with the new radio and models files. This is why it is recommended to save your sd before upgrading

@BompaBert
Copy link

10/4. Just, I had several major changes in between... All good now. Will keep you guys posted.

@BompaBert
Copy link

BompaBert commented Jul 18, 2024

FYI. Two more EM's past week on the same day. Version 2.10-2. One in flight - recovery successful. The other EM occurred while changing from model A to model B. This happened twice and so far only when using the 9 icons per page. No EM using the 4 models per page. Also after pwr off/on, model A is still active. Removed all widgets except Battcheck and Modelname. Under tools, I have only Frsky receiver scripts, the sensor_config and model locator script. Will keep you updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recovery from a hard fault (emergency mode) not working
5 participants