Addressing error: 'uint32_t' has not been declared #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In file included from /builddir/build/BUILD/edgetx-2.8.1/radio/src/gui/colorlcd/str_functions.cpp:25:
/builddir/build/BUILD/edgetx-2.8.1/radio/src/gui/colorlcd/str_functions.h:30:42: error: 'uint32_t' has not been declared
30 | extern std::string wrap(std::string str, uint32_t width);
| ^~~~~~~~
Fixes EdgeTX#3222.
1 task
|
It doesn't break any of the build system (which uses GNU 7.5.0 / AppleClang 11.0.3.11030032 / GNU 12.2.0, depending on OS) so LGTM. Just wish newer versions of the compile chain wouldn't keep breaking stuff (then again, that is part of of the reason we are use a docker container for part of it 🤷). Thanks for following this up! :) |
:-) This change is actually mentioned at https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes. |
pfeerick
pushed a commit
that referenced
this pull request
May 14, 2023
) In file included from /builddir/build/BUILD/edgetx-2.8.1/radio/src/gui/colorlcd/str_functions.cpp:25: /builddir/build/BUILD/edgetx-2.8.1/radio/src/gui/colorlcd/str_functions.h:30:42: error: 'uint32_t' has not been declared 30 | extern std::string wrap(std::string str, uint32_t width); | ^~~~~~~~ Fixes #3222.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3222.
Summary of changes:
Addressing
The change helps compilation with gcc 13 while does not negatively affect gcc 12.