Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui) - Fix layout size issue (#2961) and improve code readability. #2962

Merged
merged 1 commit into from
Jan 1, 2023

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Dec 30, 2022

Fixes #2961

Summary of changes:

Add enum for the 'decorationSettings' bits to make the code more understandable.
Fix the size check in 'getMainZone'.

@raphaelcoeffic
Copy link
Member

As a side remark: we've been discussing ditching the option to hide the top-bar to better differentiate from the full screen mode. I promised @JimB40 it would come with a simpler method for accessing the full screen mode (double tap?). What do you think?

@JimB40
Copy link
Collaborator

JimB40 commented Dec 31, 2022

Good concept. :)
Then "full-scren" without any OS UI elements will serve as "App-Mode" -> LUA run as widget controls events.
Double tap will serve well when app has this preview mode in smaller widget area to go quickly in App-Mode

I'm getting more and more confirmations that during flight time users use main views 95% with rare need to go into OS settings. They have mainviews configured as multi area layout with widgets (values, outputs ets) or 1-area-fulscreen LUA app like iNav, Yappu, Toolbox, TBS Agent, ELRS widget, etc.
All is needed in this scenario is efficient switching between main views. Switching main-view via switch was very good step
Check my walkthrough @ 49:48 when I show widgets use https://youtu.be/Ojltq2rBifM

So if we can manage to switch on APP-mode once user switch to main-view with full screen app, we have more or less phone-like solution regarding apps & desktops (main-views)

@philmoz
Copy link
Collaborator Author

philmoz commented Dec 31, 2022

As a side remark: we've been discussing ditching the option to hide the top-bar to better differentiate from the full screen mode.

Wouldn't this potentially break user's existing model setups on their radios? E.G. you have a view configured without the top bar and then the top bar suddenly comes back with no way to switch it off.

I promised @JimB40 it would come with a simpler method for accessing the full screen mode (double tap?). What do you think?

Is there a double tap event in ETX? There does not appear to be one in LVGL.

@JimB40
Copy link
Collaborator

JimB40 commented Dec 31, 2022

Is there a double tap event in ETX? There does not appear to be one in LVGL.

Not yet

@pfeerick pfeerick added color Related generally to color LCD radios bug/regression ↩️ A new version of EdgeTX broke something labels Jan 1, 2023
@pfeerick pfeerick added this to the 2.8.1 milestone Jan 1, 2023
@pfeerick pfeerick merged commit 943b1e7 into EdgeTX:main Jan 1, 2023
@philmoz philmoz deleted the main-layout-size branch September 20, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression ↩️ A new version of EdgeTX broke something color Related generally to color LCD radios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

full screen widget lost 13% area to spaces
4 participants