chore(ui): convert gvars window to LVGL #2945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, one by one |
|
Yes, that was the plan. But my next task is something less UI and more close to the HW |
1 task
1 task
|
There's a positioning (nesting?) issue going on... just try scrolling down (edit: with the scroll wheel, touch seems fine) - the header bar disappears and doesn't come back. When changing the precision, it changes the GV as displayed at the top, but not any of the other fields - they still get shown without the decimal. For reference, this is what I'm expecting to see change for min/max and FM values
The rest of my gripes are cosmetics and can be fine-tuned later ;) |
12 tasks
|
I fully concentrated on the list view regarding the decimals. I never bothered to check the edit page,🫣 |
c4a27b1 to
0b55ae5
Compare
|
Sorry for the delay. The aforementioned issues appear to be gone. Any other UI tweaks needed can be done later as this does what it says on the tin ;) |
23 tasks
pfeerick
pushed a commit
that referenced
this pull request
May 16, 2023
Formatting. chore(ui): Convert GVAR tab to LVGL (#2945) fix(ui): Adjust model setup button layout to better fit portrait screen (#2956) * Adjust model setup layout to better fix on portrait LCD screen. * Set buttons to fixed width and allow to grow vertically to fit text. * Cleanup layout logic - buttons stretched horizontally, centered vertically. fix(color): Invalid custom curves + layout updates (#2973) * Layout updates and bug fixes for curve editor. - Fix issue 2972 where an invalid curve could be created - Use vertical layout or list of points - Add border to preview to better show end points - Fix issue where preview was redrawn very frequently - Better organisation of curve edit classes * Fix to refresh curve preview on input edit page when parameters changed. chore: freeRTOS task stack diagnostics (#2976) * migrated stack diagnostics (available, free) to using built in FreeRTOS builtin function Note: main stack must be and is treated differently as it is not under FreeRTOS control. main stack is painted by the STM32 startup routine. free main stack is calculated checking the remaining painted stack area. * corrected my merge error * missed a blank fix(lua): fix drawHudRectangle for roll = 0 (#2978) - fixed an extra line at the bottom of the hud rectangle - fixed overflowing hud rectangle for horizon outside viewport (pitch > 0) fix(lua): Remove faulty carryTrim, replace with trimSource (#2995) * Fix carryTrim in LUA * Remove carryTrim feat(diags): Red LED before RTC data, blue LED after (#3006) * Added turning the red LED before RTC data and blue LED afterwards With the LED turned RED if the RTC data retrieval fails it will stay red. This will at least be an indication that the RTC startup encountered a problem. For now there is no indication that this problem occurred. * GH-3005 Moved LED manipulation to conditionally compiled when RTC operation happens fix(color): Update top bar date & time when in setup pages (#3037) fix(translation): JP had overlapping strings due to line breaks (#3004) fix(cpn): Translate OFF in external module setup (#2998) * Translate OFF in external module setup * Update moduledata.cpp Add B/W and CP support Init enabled to 1 delete extra file Fix Save/Read operations Cleanup and fix R/W Cleanup based on review Change the fields order to match YAML change the fields order to match the YAML Add headers, set new CF to enabled Remove "ON" label from "Enabled" field. Fix "disabled" when swicthing functions. Set enable==1 when changing the function. Set "enabled" if function is changed on B/W radios
philmoz
pushed a commit
that referenced
this pull request
Oct 28, 2023
Formatting. chore(ui): Convert GVAR tab to LVGL (#2945) fix(ui): Adjust model setup button layout to better fit portrait screen (#2956) * Adjust model setup layout to better fix on portrait LCD screen. * Set buttons to fixed width and allow to grow vertically to fit text. * Cleanup layout logic - buttons stretched horizontally, centered vertically. fix(color): Invalid custom curves + layout updates (#2973) * Layout updates and bug fixes for curve editor. - Fix issue 2972 where an invalid curve could be created - Use vertical layout or list of points - Add border to preview to better show end points - Fix issue where preview was redrawn very frequently - Better organisation of curve edit classes * Fix to refresh curve preview on input edit page when parameters changed. chore: freeRTOS task stack diagnostics (#2976) * migrated stack diagnostics (available, free) to using built in FreeRTOS builtin function Note: main stack must be and is treated differently as it is not under FreeRTOS control. main stack is painted by the STM32 startup routine. free main stack is calculated checking the remaining painted stack area. * corrected my merge error * missed a blank fix(lua): fix drawHudRectangle for roll = 0 (#2978) - fixed an extra line at the bottom of the hud rectangle - fixed overflowing hud rectangle for horizon outside viewport (pitch > 0) fix(lua): Remove faulty carryTrim, replace with trimSource (#2995) * Fix carryTrim in LUA * Remove carryTrim feat(diags): Red LED before RTC data, blue LED after (#3006) * Added turning the red LED before RTC data and blue LED afterwards With the LED turned RED if the RTC data retrieval fails it will stay red. This will at least be an indication that the RTC startup encountered a problem. For now there is no indication that this problem occurred. * GH-3005 Moved LED manipulation to conditionally compiled when RTC operation happens fix(color): Update top bar date & time when in setup pages (#3037) fix(translation): JP had overlapping strings due to line breaks (#3004) fix(cpn): Translate OFF in external module setup (#2998) * Translate OFF in external module setup * Update moduledata.cpp Add B/W and CP support Init enabled to 1 delete extra file Fix Save/Read operations Cleanup and fix R/W Cleanup based on review Change the fields order to match YAML change the fields order to match the YAML Add headers, set new CF to enabled Remove "ON" label from "Enabled" field. Fix "disabled" when swicthing functions. Set enable==1 when changing the function. Set "enabled" if function is changed on B/W radios
pfeerick
pushed a commit
that referenced
this pull request
Nov 12, 2023
Formatting. chore(ui): Convert GVAR tab to LVGL (#2945) fix(ui): Adjust model setup button layout to better fit portrait screen (#2956) * Adjust model setup layout to better fix on portrait LCD screen. * Set buttons to fixed width and allow to grow vertically to fit text. * Cleanup layout logic - buttons stretched horizontally, centered vertically. fix(color): Invalid custom curves + layout updates (#2973) * Layout updates and bug fixes for curve editor. - Fix issue 2972 where an invalid curve could be created - Use vertical layout or list of points - Add border to preview to better show end points - Fix issue where preview was redrawn very frequently - Better organisation of curve edit classes * Fix to refresh curve preview on input edit page when parameters changed. chore: freeRTOS task stack diagnostics (#2976) * migrated stack diagnostics (available, free) to using built in FreeRTOS builtin function Note: main stack must be and is treated differently as it is not under FreeRTOS control. main stack is painted by the STM32 startup routine. free main stack is calculated checking the remaining painted stack area. * corrected my merge error * missed a blank fix(lua): fix drawHudRectangle for roll = 0 (#2978) - fixed an extra line at the bottom of the hud rectangle - fixed overflowing hud rectangle for horizon outside viewport (pitch > 0) fix(lua): Remove faulty carryTrim, replace with trimSource (#2995) * Fix carryTrim in LUA * Remove carryTrim feat(diags): Red LED before RTC data, blue LED after (#3006) * Added turning the red LED before RTC data and blue LED afterwards With the LED turned RED if the RTC data retrieval fails it will stay red. This will at least be an indication that the RTC startup encountered a problem. For now there is no indication that this problem occurred. * GH-3005 Moved LED manipulation to conditionally compiled when RTC operation happens fix(color): Update top bar date & time when in setup pages (#3037) fix(translation): JP had overlapping strings due to line breaks (#3004) fix(cpn): Translate OFF in external module setup (#2998) * Translate OFF in external module setup * Update moduledata.cpp Add B/W and CP support Init enabled to 1 delete extra file Fix Save/Read operations Cleanup and fix R/W Cleanup based on review Change the fields order to match YAML change the fields order to match the YAML Add headers, set new CF to enabled Remove "ON" label from "Enabled" field. Fix "disabled" when swicthing functions. Set enable==1 when changing the function. Set "enabled" if function is changed on B/W radios
pfeerick
pushed a commit
that referenced
this pull request
Nov 12, 2023
Formatting. chore(ui): Convert GVAR tab to LVGL (#2945) fix(ui): Adjust model setup button layout to better fit portrait screen (#2956) * Adjust model setup layout to better fix on portrait LCD screen. * Set buttons to fixed width and allow to grow vertically to fit text. * Cleanup layout logic - buttons stretched horizontally, centered vertically. fix(color): Invalid custom curves + layout updates (#2973) * Layout updates and bug fixes for curve editor. - Fix issue 2972 where an invalid curve could be created - Use vertical layout or list of points - Add border to preview to better show end points - Fix issue where preview was redrawn very frequently - Better organisation of curve edit classes * Fix to refresh curve preview on input edit page when parameters changed. chore: freeRTOS task stack diagnostics (#2976) * migrated stack diagnostics (available, free) to using built in FreeRTOS builtin function Note: main stack must be and is treated differently as it is not under FreeRTOS control. main stack is painted by the STM32 startup routine. free main stack is calculated checking the remaining painted stack area. * corrected my merge error * missed a blank fix(lua): fix drawHudRectangle for roll = 0 (#2978) - fixed an extra line at the bottom of the hud rectangle - fixed overflowing hud rectangle for horizon outside viewport (pitch > 0) fix(lua): Remove faulty carryTrim, replace with trimSource (#2995) * Fix carryTrim in LUA * Remove carryTrim feat(diags): Red LED before RTC data, blue LED after (#3006) * Added turning the red LED before RTC data and blue LED afterwards With the LED turned RED if the RTC data retrieval fails it will stay red. This will at least be an indication that the RTC startup encountered a problem. For now there is no indication that this problem occurred. * GH-3005 Moved LED manipulation to conditionally compiled when RTC operation happens fix(color): Update top bar date & time when in setup pages (#3037) fix(translation): JP had overlapping strings due to line breaks (#3004) fix(cpn): Translate OFF in external module setup (#2998) * Translate OFF in external module setup * Update moduledata.cpp Add B/W and CP support Init enabled to 1 delete extra file Fix Save/Read operations Cleanup and fix R/W Cleanup based on review Change the fields order to match YAML change the fields order to match the YAML Add headers, set new CF to enabled Remove "ON" label from "Enabled" field. Fix "disabled" when swicthing functions. Set enable==1 when changing the function. Set "enabled" if function is changed on B/W radios
pfeerick
pushed a commit
that referenced
this pull request
Nov 27, 2023
Formatting. chore(ui): Convert GVAR tab to LVGL (#2945) fix(ui): Adjust model setup button layout to better fit portrait screen (#2956) * Adjust model setup layout to better fix on portrait LCD screen. * Set buttons to fixed width and allow to grow vertically to fit text. * Cleanup layout logic - buttons stretched horizontally, centered vertically. fix(color): Invalid custom curves + layout updates (#2973) * Layout updates and bug fixes for curve editor. - Fix issue 2972 where an invalid curve could be created - Use vertical layout or list of points - Add border to preview to better show end points - Fix issue where preview was redrawn very frequently - Better organisation of curve edit classes * Fix to refresh curve preview on input edit page when parameters changed. chore: freeRTOS task stack diagnostics (#2976) * migrated stack diagnostics (available, free) to using built in FreeRTOS builtin function Note: main stack must be and is treated differently as it is not under FreeRTOS control. main stack is painted by the STM32 startup routine. free main stack is calculated checking the remaining painted stack area. * corrected my merge error * missed a blank fix(lua): fix drawHudRectangle for roll = 0 (#2978) - fixed an extra line at the bottom of the hud rectangle - fixed overflowing hud rectangle for horizon outside viewport (pitch > 0) fix(lua): Remove faulty carryTrim, replace with trimSource (#2995) * Fix carryTrim in LUA * Remove carryTrim feat(diags): Red LED before RTC data, blue LED after (#3006) * Added turning the red LED before RTC data and blue LED afterwards With the LED turned RED if the RTC data retrieval fails it will stay red. This will at least be an indication that the RTC startup encountered a problem. For now there is no indication that this problem occurred. * GH-3005 Moved LED manipulation to conditionally compiled when RTC operation happens fix(color): Update top bar date & time when in setup pages (#3037) fix(translation): JP had overlapping strings due to line breaks (#3004) fix(cpn): Translate OFF in external module setup (#2998) * Translate OFF in external module setup * Update moduledata.cpp Add B/W and CP support Init enabled to 1 delete extra file Fix Save/Read operations Cleanup and fix R/W Cleanup based on review Change the fields order to match YAML change the fields order to match the YAML Add headers, set new CF to enabled Remove "ON" label from "Enabled" field. Fix "disabled" when swicthing functions. Set enable==1 when changing the function. Set "enabled" if function is changed on B/W radios
pfeerick
pushed a commit
that referenced
this pull request
Dec 3, 2023
Formatting. chore(ui): Convert GVAR tab to LVGL (#2945) fix(ui): Adjust model setup button layout to better fit portrait screen (#2956) * Adjust model setup layout to better fix on portrait LCD screen. * Set buttons to fixed width and allow to grow vertically to fit text. * Cleanup layout logic - buttons stretched horizontally, centered vertically. fix(color): Invalid custom curves + layout updates (#2973) * Layout updates and bug fixes for curve editor. - Fix issue 2972 where an invalid curve could be created - Use vertical layout or list of points - Add border to preview to better show end points - Fix issue where preview was redrawn very frequently - Better organisation of curve edit classes * Fix to refresh curve preview on input edit page when parameters changed. chore: freeRTOS task stack diagnostics (#2976) * migrated stack diagnostics (available, free) to using built in FreeRTOS builtin function Note: main stack must be and is treated differently as it is not under FreeRTOS control. main stack is painted by the STM32 startup routine. free main stack is calculated checking the remaining painted stack area. * corrected my merge error * missed a blank fix(lua): fix drawHudRectangle for roll = 0 (#2978) - fixed an extra line at the bottom of the hud rectangle - fixed overflowing hud rectangle for horizon outside viewport (pitch > 0) fix(lua): Remove faulty carryTrim, replace with trimSource (#2995) * Fix carryTrim in LUA * Remove carryTrim feat(diags): Red LED before RTC data, blue LED after (#3006) * Added turning the red LED before RTC data and blue LED afterwards With the LED turned RED if the RTC data retrieval fails it will stay red. This will at least be an indication that the RTC startup encountered a problem. For now there is no indication that this problem occurred. * GH-3005 Moved LED manipulation to conditionally compiled when RTC operation happens fix(color): Update top bar date & time when in setup pages (#3037) fix(translation): JP had overlapping strings due to line breaks (#3004) fix(cpn): Translate OFF in external module setup (#2998) * Translate OFF in external module setup * Update moduledata.cpp Add B/W and CP support Init enabled to 1 delete extra file Fix Save/Read operations Cleanup and fix R/W Cleanup based on review Change the fields order to match YAML change the fields order to match the YAML Add headers, set new CF to enabled Remove "ON" label from "Enabled" field. Fix "disabled" when swicthing functions. Set enable==1 when changing the function. Set "enabled" if function is changed on B/W radios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
gvars window proted to LVGL