fix(color): Display of model notes when selecting model #2922
Conversation
Fixes issues 2722 and 2921.
|
See #2792 :-) |
|
@eshifri I was looking at the way you fixed this in 2792 and thought this was an easier way to do it. Hopefully not stepping on anyones toes by posting a new PR. |
|
My toes are perfectly OK. :-) |
|
Should this not go around ln 392? i.e. if you abort during the model telemetry confirmation prompt, you will leave the model select screen with the current implementation, rather than being "returned" to it (and thus having to retrace your steps once you resolve the issue)? Otherwise, yeah, I think this should be better/simpler... |
|
Working flawlessly on TX16S with a telemetry RX blocking the model switch - returns to model select screen if model switch is not confirmed. Pre-flight checklist is being shown after the model switch when configured, and then the main screen. |
* Fix display of model notes when selecting model. Fixes issues 2722 and 2921. * Move view close code as suggested by @pfeerick.
* Fix display of model notes when selecting model. Fixes issues 2722 and 2921. * Move view close code as suggested by @pfeerick.
Alternate solution to the one in PR #2792
My testing on TX16S and in the simulator has no issues; but if there are reasons why doing it this way won't work please let me know.
Fixes #2722 and #2921
Summary of changes:
Close model select page before loading model so notes window is not hidden.