-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(color): Clear Lua lcd buffer and display 'Loading...' #2916
Conversation
PL |
370e5e1
to
32478f6
Compare
I had actually done this a while ago, but didn't like it as it means for lighter scripts it means the screen flashes black between the tools and the lua script... so had explored trying to pre-load the lua buffer with the the last frame from the regular double-frame buffer and drawing the loading message on that, but hadn't managed to get that working consistently. So this will at least stop the complaints about screen garbage / last Lua script frame being shown :) |
Can we get some translations for this please 😃 It gets written to the middle of the screen while a Tools Lua script is being loaded
@HThuren DA |
@pfeerick DE is already in the review, but here again |
32478f6
to
b9aae8f
Compare
CZ: Načítání... |
IT |
SE
#define TR_LOADING "Laddar..."
|
JP |
DK |
99ac948
to
96bb40d
Compare
CN TW |
96bb40d
to
044c439
Compare
* Clear LCD buffer before use for standalone Lua scripts. * Fix rebase merge issues. * Add translation. * Add translation. * Add translations. * Add translation/ Co-authored-by: Phil Mitchell <phil.a.mitchell@gmail.com>
Fixes #2810
Summary of changes:
Clear the Lcd buffer and display "Loading..." text in the constructor for StandaloneLuaWindow