Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(color): Clear Lua lcd buffer and display 'Loading...' #2916

Merged
merged 6 commits into from
Dec 28, 2022

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Dec 21, 2022

Fixes #2810

Summary of changes:

Clear the Lcd buffer and display "Loading..." text in the constructor for StandaloneLuaWindow

@pfeerick pfeerick linked an issue Dec 21, 2022 that may be closed by this pull request
2 tasks
@pfeerick pfeerick added bug 🪲 Something isn't working color Related generally to color LCD radios labels Dec 21, 2022
@pfeerick pfeerick changed the title fix(color) - Clear Lua lcd buffer and display a 'Loading... fix(color): Clear Lua lcd buffer and display 'Loading...' Dec 21, 2022
@ajjjjjjjj
Copy link
Contributor

PL
#define TR_LOADING "Ładowanie..."

@philmoz philmoz force-pushed the clear-lua-lcd-buffer branch from 370e5e1 to 32478f6 Compare December 21, 2022 23:06
@pfeerick
Copy link
Member

I had actually done this a while ago, but didn't like it as it means for lighter scripts it means the screen flashes black between the tools and the lua script... so had explored trying to pre-load the lua buffer with the the last frame from the regular double-frame buffer and drawing the loading message on that, but hadn't managed to get that working consistently. So this will at least stop the complaints about screen garbage / last Lua script frame being shown :)

@pfeerick
Copy link
Member

Can we get some translations for this please 😃

It gets written to the middle of the screen while a Tools Lua script is being loaded

#define TR_LOADING "Loading..."

@HThuren DA
@ParkerEde DE
@Eldenroot CZ
@ulfhedlund SE
@robustini IT
@zyren CN / TW
@ajjjjjjjj PL Thanks for beating me to the punch :)
@ToshihiroMakuuchi JP

@TheIsotopes
Copy link
Contributor

TheIsotopes commented Dec 22, 2022

@pfeerick DE is already in the review, but here again
#define TR_LOADING "Wird geladen..."

@philmoz philmoz force-pushed the clear-lua-lcd-buffer branch from 32478f6 to b9aae8f Compare December 22, 2022 09:32
radio/src/translations/de.h Outdated Show resolved Hide resolved
@Eldenroot
Copy link
Contributor

CZ: Načítání...

@pfeerick pfeerick added this to the 2.8.1 milestone Dec 22, 2022
@robustini
Copy link
Contributor

IT
#define TR_LOADING "Caricamento..."

@ulfhedlund
Copy link
Contributor

ulfhedlund commented Dec 22, 2022 via email

@ToshihiroMakuuchi
Copy link
Contributor

JP
#define TR_LOADING "読み込み中..."

@HThuren
Copy link
Contributor

HThuren commented Dec 22, 2022

DK
#define TR_LOADING "Indlæser..."

@philmoz philmoz force-pushed the clear-lua-lcd-buffer branch 2 times, most recently from 99ac948 to 96bb40d Compare December 24, 2022 05:09
@zyren
Copy link
Contributor

zyren commented Dec 26, 2022


CN
#define TR_LOADING "加载中..."



TW
#define TR_LOADING "加載中..."


@philmoz philmoz force-pushed the clear-lua-lcd-buffer branch from 96bb40d to 044c439 Compare December 26, 2022 21:18
@pfeerick pfeerick merged commit 277c1ca into EdgeTX:main Dec 28, 2022
pfeerick pushed a commit that referenced this pull request Jan 25, 2023
* Clear LCD buffer before use for standalone Lua scripts.

* Fix rebase merge issues.

* Add translation.

* Add translation.

* Add translations.

* Add translation/

Co-authored-by: Phil Mitchell <phil.a.mitchell@gmail.com>
@philmoz philmoz deleted the clear-lua-lcd-buffer branch September 20, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working color Related generally to color LCD radios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screen buffer corruption on standalone Lua launch [Color LCD] Display buffer bugs
10 participants