fix(color) - Fix file handle leak in theme manager. #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mha1
pushed a commit
to mha1/edgetx
that referenced
this pull request
Dec 22, 2022
pfeerick
pushed a commit
that referenced
this pull request
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ThemePersistance::scanThemeFolder method was not closing the file it opened, leaking a file handle for each theme on the SD card.
The themes are only scanned once on startup so not a huge issue on a radio.
However, at least on MacOS, this eventually crashes the simulator / companion if the radio is reloaded in the simulator or the simulator is closed and opened multiple times.
Summary of changes:
Close the file handle in ThemePersistance::scanThemeFolder.