Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ACCESS): configure AUX serial port as "External module" #2562

Merged
merged 3 commits into from
Dec 14, 2022

Conversation

raphaelcoeffic
Copy link
Member

@raphaelcoeffic raphaelcoeffic commented Oct 15, 2022

Description

This allows configuring the external access mod on runtime rather than by compilation option.

First, configure the hardware port (only available on AUX1 as AUX2 has no TX DMA)
Screenshot 2022-10-15 at 20 46 59

Then the module can be chosen:
Screenshot 2022-10-15 at 20 47 42

TODO:

  • Companion support (separate PR)

@raphaelcoeffic raphaelcoeffic force-pushed the aux-access-mod branch 2 times, most recently from 508c95c to 45010b1 Compare October 15, 2022 17:47
raphaelcoeffic added a commit that referenced this pull request Oct 15, 2022
This allows configuring the external access mod on runtime rather than by compilation option.
raphaelcoeffic added a commit that referenced this pull request Oct 15, 2022
This allows configuring the external access mod on runtime rather than by compilation option.
raphaelcoeffic added a commit that referenced this pull request Oct 15, 2022
This allows configuring the external access mod on runtime rather than by compilation option.
@raphaelcoeffic raphaelcoeffic marked this pull request as ready for review October 15, 2022 18:41
@raphaelcoeffic raphaelcoeffic added this to the 2.9 milestone Oct 15, 2022
@HThuren
Copy link
Contributor

HThuren commented Nov 4, 2022

DA translation

#define TR_AUX_SERIAL_MODES            "FRA","Telem spejl","Telemetri ind","SBUS træner","LUA","CLI","GPS","Debug","SpaceMouse","Eksternt modul"

@Eldenroot
Copy link
Contributor

Eldenroot commented Nov 5, 2022

CZ translation:

#define TR_AUX_SERIAL_MODES            "VYP","Telemetrie zrcadlení","Telemetrie vstup","SBUS Trenér","LUA","CLI","GPS","Debug","SpaceMouse","Externí modul"

@raphaelcoeffic
Copy link
Member Author

@HThuren @Eldenroot please note that you guys can make PRs against this PR's branch ;-)

@HThuren
Copy link
Contributor

HThuren commented Nov 6, 2022

Well, havn't tried (yet :-) ), have to figure out how to

@brainbubblersbest
Copy link

All Warp Levels Working on X12S Enterprise.
And in all Territorys ;D

This allows configuring the external access mod on runtime rather than by compilation option.
@pfeerick
Copy link
Member

Confirmed working on TX16S MK2 (ELRS) with externalaccess mod. R9M+2019 module running FCC firmware, and was able to register, bind, and configure options on both module and R9 SX receiver. If connecting directly to AUX1, inverters needed.

@pfeerick pfeerick merged commit 06c359f into main Dec 14, 2022
@pfeerick pfeerick deleted the aux-access-mod branch December 14, 2022 08:41
mha1 pushed a commit to mha1/edgetx that referenced this pull request Dec 22, 2022
…2562)

* Enable RX DMA on external module USART

* feat(ACCESS): configure AUX serial port as "External module" (EdgeTX#2562)

This allows configuring the external access mod on runtime rather than by compilation option.

* fix: fetch external module driver
@edwardrf
Copy link

I'll apologise for my limited understanding of the firmware, I would like to understand this portion of the logic:

#if !defined(AUX_SERIAL_DMA_TX) || defined(EXTMODULE_USART)
  if (mode == UART_MODE_EXT_MODULE)
    return false;
#else // defined(AUX_SERIAL_DMA_TX) && !defined(EXTMODULE_USART)
  // UART_MODE_EXT_MODULE is only supported on AUX1, as AUX2 has no TX DMA
  if (mode == UART_MODE_EXT_MODULE && port_nr != SP_AUX1)
    return false;
#endif

Why AUX1 cannot be set to module if EXTMODULE_USART is defined? I am wondering if I can wire in another module internally in to my RadioMaster Pocket, which apparently has an empty UART port on the main board.

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants