feat(color): single press to trigger model select menu #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a similar way as the file preview, using the ENTER key will trigger the menu, while touching a preview unselected model will just select it in the list. A second tap will then trigger the menu.
1 task
|
The current behaviour of the model select screen is for a long press to bring up the menu at any time, whereas this prevents that, but exchanges it for allowing a double tap behaviour (although it is really two single taps - the first selects, the second brings up the menu if the second tap is on the same model icon). As you say, this makes it consistent with how the SD card browser works - as that behaves exactly the same way. I wouldn't mind seeing the long press behaviour restored, so that a long press would select+bring up the menu, for both file browser, and model select. but that can be a future improvement. As well as the possibility of in the case of model select there being an option (off by default) for model selection to happen on the second click, since a long press would bring up the menu. This is part of a longer discussion I think though. VID_20221013_123014.mp4 |
pfeerick
pushed a commit
that referenced
this pull request
Oct 13, 2022
In a similar way as the file preview, using the ENTER key will trigger the menu, while touching a preview unselected model will just select it in the list. A second tap will then trigger the menu.
shane-droid
added a commit
to shane-droid/edgetx
that referenced
this pull request
Aug 12, 2023
…icSwitch2-testmergeMain-18oct22 * 'main' of https://github.com/EdgeTX/edgetx: (101 commits) feat(color): mix/output bars show '0%' (EdgeTX#2592) fix(lua): send EVT_VIRTUAL_EXIT only on short EXIT press (EdgeTX#2573) fix(color): Write pending changes to model before duplicate (EdgeTX#2579) fix(color): min/max highlighting should depend on mixer channel value (EdgeTX#2582) fix(gf): reset global function context if disabled (EdgeTX#2578) fix(color): clear spectrum analyser data buffer on init fix(color): check `theme` before accessing it fix(cpn): Workaround MacOS 13 filesystem type change (EdgeTX#2564) chore(adc): store constant structs in FLASH (EdgeTX#2551) fix(color): copy/paste inputs/mixers (EdgeTX#2545) fix(color): RF power drop-down (EdgeTX#2547) fix(color): module setup sub-type after selecting MPM (EdgeTX#2548) fix(B&W): `a~x` not being displayed correctly (EdgeTX#2539) fix(X10): Simulated page up in menu toolbar (EdgeTX#2543) fix: hard coded special characters (EdgeTX#2538) feat(color): single press to trigger model select menu (EdgeTX#2533) fix(color): shortcut for model select (EdgeTX#2528) fix(color): screen / widget setup (EdgeTX#2532) fix(NV14/EL18): Reduce LCD pixel clock to 1000000 (EdgeTX#2525) fix: clear internal module FIFO after DMA init (EdgeTX#2527) ... # Conflicts: # radio/src/fonts/lvgl/lv_font_noto_cn_24.c # radio/src/fonts/lvgl/lv_font_noto_tw_24.c # radio/src/gui/colorlcd/model_mixes.cpp # radio/src/gui/colorlcd/output_edit.cpp # radio/src/gui/colorlcd/screen_setup.cpp # radio/src/gui/colorlcd/view_about.cpp # radio/src/storage/modelslist.cpp # radio/src/translations/cn.h # radio/src/translations/de.h # radio/src/translations/en.h # radio/src/translations/se.h # radio/src/translations/tw.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a similar way as the file preview, using the ENTER key will trigger the menu, while touching a preview unselected model will just select it in the list. A second tap will then trigger the menu.
Fixes #2510