Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(telemetry): extend link quality warnings range #2251

Merged
merged 3 commits into from
Oct 12, 2022
Merged

feat(telemetry): extend link quality warnings range #2251

merged 3 commits into from
Oct 12, 2022

Conversation

raphaelcoeffic
Copy link
Member

@raphaelcoeffic raphaelcoeffic commented Aug 30, 2022 •
edited
Loading

This PR should allow to setup telemetry warnings in a useful way for protocols requiring higher warning values, such as ELRS / Crossfire where the link quality reported is actually a percentage.

Fixes #2205

Summary of changes:

  • extend warning values range to a full byte (from 6 bits).
  • moved disable bit to the others.

TODOs:

  • companion support
  • set useful default values (45/42 as per legacy)

@raphaelcoeffic raphaelcoeffic mentioned this pull request Aug 30, 2022
Closed
1 task
@pfeerick pfeerick added UX-UI Related to user experience (UX) or user interface (UI) behaviour telemetry 📶 labels Aug 30, 2022
@raphaelcoeffic raphaelcoeffic force-pushed the telemetry-warnings branch 2 times, most recently from 8e6a62e to cf021cb Compare September 1, 2022 04:37
@raphaelcoeffic raphaelcoeffic added this to the 2.8 milestone Oct 10, 2022
@pfeerick
Copy link
Member

Will play with in the morning, with a view to merge for nightly.

@pfeerick pfeerick self-assigned this Oct 11, 2022
@pfeerick
Copy link
Member

Triggered a rebase build due to a error I was getting in Companion, and unfotunately found out whilst waiting for that to build it was a bug elsewhere in Companion I hadn't run into before... so this missed the nightly. It's going into RC3 anyway 😆
image

@pfeerick pfeerick merged commit 6f494e1 into main Oct 12, 2022
@pfeerick pfeerick deleted the telemetry-warnings branch October 12, 2022 04:28
pfeerick pushed a commit that referenced this pull request Oct 12, 2022
@raphaelcoeffic @pfeerick
feat(telemetry): extend link quality warnings range (#2251)
64a87bf 
* feat(telemetry): extend link quality warnings range

* Set default values to the old legacy FrSky values

* Companion support
@pfeerick pfeerick mentioned this pull request Oct 17, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pfeerick pfeerick

Labels
telemetry 📶 UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.

Telemetry Alert Range
2 participants
@raphaelcoeffic @pfeerick