Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with flex switches and switch warning #4938

Closed
1 task done
3djc opened this issue Apr 28, 2024 · 1 comment · Fixed by #4949
Closed
1 task done

Issue with flex switches and switch warning #4938

3djc opened this issue Apr 28, 2024 · 1 comment · Fixed by #4949
Labels
blocks-release Releases shouldn't go out without this fix bug 🪲 Something isn't working
Milestone

Comments

@3djc
Copy link
Collaborator

3djc commented Apr 28, 2024

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

There is an issue with YAML saving of customs switches. The warnings are using only 1 leter to save instead of the usual format.
SA.SB,.. are saved as A,B,...
FL, FL2,.. are saved as .... L (all of them)

So when read, only FL1 gets populated, with the value of the last FL been encoded in warnings

Expected Behavior

Flex are saved in an error free format

Steps To Reproduce

Create flex switches, assign several to switch warning. Turn off, turn on. oh noooo

Version

Nightly (Please give date/commit below)

Transmitter

RadioMaster MT12

Operating System (OS)

No response

OS Version

No response

Anything else?

No response

@3djc 3djc added bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels Apr 28, 2024
@3djc
Copy link
Collaborator Author

3djc commented Apr 28, 2024

This is another son (or daughter) of you know what 2.10 PR :D.

The faulty fonction is switchGetLetter() (fortunatly used only to save switch warnings). I'm discussion with @raphaelcoeffic the best way forward

Solution will have to involve companion too

@3djc 3djc added this to the 2.10 milestone Apr 28, 2024
@3djc 3djc added the blocks-release Releases shouldn't go out without this fix label Apr 28, 2024
raphaelcoeffic added a commit that referenced this issue May 1, 2024
raphaelcoeffic added a commit that referenced this issue May 1, 2024
@pfeerick pfeerick removed the triage Bug report awaiting review / sorting label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocks-release Releases shouldn't go out without this fix bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants