Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPS value widget does not update #4170

Closed
1 task done
archmod101 opened this issue Oct 6, 2023 · 4 comments · Fixed by #4250
Closed
1 task done

GPS value widget does not update #4170

archmod101 opened this issue Oct 6, 2023 · 4 comments · Fixed by #4250
Labels
bug 🪲 Something isn't working triage Bug report awaiting review / sorting

Comments

@archmod101
Copy link

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

I have a value widget set to GPS telemetry, but it does not update unless I move to another screen and then back to it.

Note: This is on 2.9.1, not 2.9 as highest selectable in Version drop down.

Expected Behavior

GPS value widget should update as the data comes in.

Steps To Reproduce

  1. Set a value widget to GPS.
  2. With incoming telemetry data verified, observe GPS value.
  3. Move to another and then back to the screen with the GPS value widget.

Version

2.9.0

Transmitter

Radiomaster TX16S / TX16SMK2

Operating System (OS)

No response

OS Version

No response

Anything else?

No response

@archmod101 archmod101 added bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels Oct 6, 2023
@archmod101 archmod101 changed the title GPS value does not always update GPS value widget does not update Oct 6, 2023
@pfeerick
Copy link
Member

pfeerick commented Oct 7, 2023

Has this changed between 2.9.0 and 2.9.1? As I'm wondering if #4071 is the culprit somehow.

@archmod101
Copy link
Author

I don't recall noticing this in 2.9

@frankiearzu
Copy link
Contributor

frankiearzu commented Oct 14, 2023

I don't think that #4071 is the culprit. The value handling is for specific data types; GPS is separate. Will check out Spektrum.

@frankiearzu
Copy link
Contributor

frankiearzu commented Oct 26, 2023

Found the problem... anything that is not a single 32bit value will not refresh by default. We need to do the same trick as in #4071 that is to populate the "value" to something that changes based on the complex datatypes (text, GPS, date_time). It did not refresh in previous versions either (2.8.5)

While testing this also found that DATE_TIME is not been display correctly in the value widget (color). Fixed it too.
Creating a PR.

frankiearzu added a commit to frankiearzu/edgetx that referenced this issue Oct 26, 2023
Fixes refresh of GPS and DATETIME values on Value Widget (color)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working triage Bug report awaiting review / sorting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants