2.9 Themes

[tourerjim]

Is there an existing issue for this problem?

• I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

TX16s MKII updated to 2.9 but my own Themes screen goes black and not able to read anything from the screen, went back to 2.8.4 and my Themes screens fine and with 2.8.3

Cant edit my Themes on 2.9, cant see 'Edit' or the drop down to edit.

Expected Behavior

I assume I just copy over my sc card content and my theme.yml works

Steps To Reproduce

If I change from EdgeTX theme to my theme screen goes black

Version

2.8.4

Transmitter

Radiomaster TX16S / TX16SMK2

Operating System (OS)

Windows

OS Version

none

Anything else?

No response

[philmoz]

Please post your theme.yml file here so we can see what is wrong. You will need to rename it to theme.yml.txt.

[tourerjim]

________________________________ From: philmoz ***@***.***> Sent: 04 July 2023 23:12 To: EdgeTX/edgetx ***@***.***> Cc: tourerjim ***@***.***>; Author ***@***.***> Subject: Re: [EdgeTX/edgetx] 2.9 Themes (Issue #3760) Please post your theme.yml file here so we can see what is wrong. You will need to rename it to theme.yml.txt. — Reply to this email directly, view it on GitHub<#3760 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/APXDJIR4HIKRTV57S6VKXR3XOSINRANCNFSM6AAAAAAZ57DOQY>. You are receiving this because you authored the thread.Message ID: ***@***.***>

…

--- summary: name: FM2M_005 author: Jim info: theme 005 colors: PRIMARY1: 0x000000 PRIMARY2: 0xF0FCF0 PRIMARY3: 0xF80000 SECONDARY1: 0x000400 SECONDARY2: 0xA8ACA8 SECONDARY3: 0xB8CCE0 FOCUS: 0x407400 EDIT: 0x4890E0 ACTIVE: 0xF8E418 WARNING: 0xB0B0B0 DISABLED: 0x808080

[pfeerick]

You'll need to upload this on Github - email attachments are ignored.

[tourerjim]

theme.yml.txt..txt

[philmoz]

Open the file in a text editor and remove the blank line before the 'colors:' section.

[philmoz]

There was a bug in the YAML parser handling of blank lines.

2.9 changed the theme parser to use the same one as used by the model and radio files (which historically did not have blank lines unlike themes).

This should get fixed in a later version; but in the meantime you can work around it by removing any blank lines in the theme.yml file.

[tourerjim]

Thank you, removing blank lines my themes are now working with 2.9

[tourerjim]

Unfortunately there is still bit of an issue, to get my theme working I need to edit within your theme, correcting the spacing only worked when I edited within your theme ie FM2M_Concrete, if I transfer my theme from 2.8.4 or write my own it will not work and looking at the two pictures may help.
picture 1 is your .yml file (FM2M_Concrete) and file shows thunbnail blank, my edit picture 2 saved as .yml shows text lines on thumbnail.

[tourerjim]

Your file (edited FM2M_Concrete)

[philmoz]

Check that Windows is not hiding a .txt extension on the edited file.

[tourerjim]

Could you show example, I save in Notepad as theme.yml

[pfeerick]

In your own screenshot, you can't see an extension for the logo file, so the extension for your theme file may or may not be .yml. You need to go into the file explorer options, and untick the "hide extensions for known file types" option.

Alternately, when you save it in Notepad, make sure you change the save as type from text document (*.txt) to All files (*.*), otherwise Notepad will always append .txt to the filename whatever you give it ;)

btw, I updated all the themes in the theme directory that have a blank line to remove them, so you can also just download the latest version of it from https://github.com/EdgeTX/themes/releases ;)

[tourerjim]

Thank you, I'll try that.

[tourerjim]

Alls good now, on 2.8.4 or lower I didn't have issues with image naming 'logo' and saving or .yml files in Notepad, but something has changed in 2.9 saving logo is now saved as logo.png & theme.yml as your 'image file options' theme.yml is now saved as 'all file types.

[pfeerick]

Neither the extension for the logo file (.png) or the theme file (.yml) have changed in 2.9, only how the theme file itself is read/written by the firmware.

Have a look at the name of the option in your file browser we directed you to, it isn't just "hide file extensions", it's "hide known file extensions". In the first screenshot you showed in #3760 (comment), your windows install doesn't recognise the file type, so shows a generic icon. In the second screenshot, it shows a different icon, hence the file extension (which you can't see, otherwise you'd also be able to see the extension for the logo file next to it was .png), so really that file was called theme.yml.txt, which is invalid. If you check on the radio using the SD browser, you'll see this also. You really need to turn that option off so that it isn't misleading you.

[tourerjim]

Not sure if it's to do with Windows which done update on my laptop couple days prior to me updating to 2.9.
For me to edit theme.yml to work with 2.9 this is the file thumbnail that shows in Themes.

If I drop this file to here I get message (we don't support that file) but and strange thing is that same file works with 2.9 Themes.

[pfeerick]

More importantly, you can now see the file extensions for both, so know they are both correct. If you wanted to upload it to github, you would have to do what philmoz said back at #3760 (comment), which was

You will need to rename it to theme.yml.txt.

in other words, change the file extension so it ends with .txt, which is what GitHub said was one of the supported file extensions when you tried to upload the file. I think this is how you got yourself confused before, as when you changed the filename from theme.yml to theme.yml.txt, it became a "recognised file type", and thus the extension was hidden, meaning you could only see theme.yml. It's only when you turned that extension hiding nonsense off that you can see what the true file extension was.

Anyway, the important thing here is there was a change in how EdgeTX 2.9 reads/writes theme.yml files which you've helped us identify, and it's just a matter of ensuring there are no blank lines in the file to confuse the firmware.

[tourerjim]

Your helps are well appreciated, an old boy trying to keep up with all this tech and am really pleased I've got all my own themes back now working.
Thank you.