Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression? New mixes being forgotten. #3367

Closed
1 task done
sixtyfive opened this issue Mar 18, 2023 · 18 comments · Fixed by #3999
Closed
1 task done

Regression? New mixes being forgotten. #3367

sixtyfive opened this issue Mar 18, 2023 · 18 comments · Fixed by #3999
Assignees
Labels
bug 🪲 Something isn't working
Milestone

Comments

@sixtyfive
Copy link

sixtyfive commented Mar 18, 2023

The below issue occurs only with 2.8.1, not 2.8.0.

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

When setting up a mix other than the 5 defaults (them being the 4 stick movements as well as Arm/Disarm on switch SC), and then rebooting the transmitter, any additions made to the Mixes tab are then gone again.

Changes to one of the 5 defaults are retained, only additions are forgotten.

Expected Behavior

Adding a mix and rebooting retains that mix throughout reboots.

Steps To Reproduce

  1. Turn transmitter on
  2. Long-press "Enter" button
  3. Right-press right thumbstick to page 5/11 ("Mixes")
  4. Down-press right thumbstick to CH6
  5. Press "Enter" button
  6. Down-press right thumbstick once
  7. Press "Enter" button (selection blinks)
  8. Operate SD button
  9. Press "Enter" button (selection stops blinking)
  10. Press "Exit" button, observe new mix is now set up
  11. Press "Exit" button again
  12. Turn transmitter off
  13. Turn transmitter on again,
  14. Navigate to "Mixes" again, observe new mix is missing

Transmitter

BetaFPV LiteRadio3 Pro

@sixtyfive sixtyfive added bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels Mar 18, 2023
@sixtyfive sixtyfive changed the title Mixes being forgotten Regression: new mixes being forgotten Mar 22, 2023
@sixtyfive sixtyfive changed the title Regression: new mixes being forgotten Regression? New mixes being forgotten. Mar 22, 2023
@VitalyKondratiev
Copy link

I didnt catch this bug on 2.8.1, but yesterday I upgrade EdgeTX to 2.8.2, and get this problem.
Downgrade to 2.8.1 saves the bug, but downgraded to 2.8.0 removes the bug
I have BetaFPV LiteRadio 3 Pro too.

@oloendithas
Copy link

oloendithas commented Apr 22, 2023

Experiencing the same issue on 2.8.2.

UPDATE: still exist on 2.8.3

@pfeerick pfeerick removed the triage Bug report awaiting review / sorting label Apr 23, 2023
@oloendithas
Copy link

Issue persists on 2.8.4

@oloendithas
Copy link

2.10-nightly still not fixed

@pfeerick
Copy link
Member

pfeerick commented Jul 1, 2023

I saw recent reference to this suggesting it only happens on the existing models, not new models... can you try creating a new model and seeing if this still happens.

BTW, main / nightlies are in no way safe to fly atm. Stick with 2.8.x or the 2.9 branch for now, other than for testing.

@oloendithas
Copy link

Oh, indeed. Newly created model does not suffer from this issue (on 2.8.4).
Thanks for the clue!

@paulo-serrao
Copy link

paulo-serrao commented Sep 3, 2023

I am encountering the same issue, my radio is the RadioMaster Pocket.

Here is an example of a model with this issue, if I set mixer CH7, I loose it after a reboot (or simply switching to a different model).

model02.zip

Workaround: I manually edited the YAML file with a text editor, removed the mixers content (under mixData section) and then recreated everything from scratch thru the radio. It is now working fine.

@raphaelcoeffic raphaelcoeffic self-assigned this Sep 3, 2023
@raphaelcoeffic raphaelcoeffic added this to the 2.9.x milestone Sep 3, 2023
raphaelcoeffic added a commit that referenced this issue Sep 3, 2023
@raphaelcoeffic
Copy link
Member

raphaelcoeffic commented Sep 3, 2023

@paulo-serrao thx for the file!

What happens here is the following:

  • the file has been copied from another radio,
  • which had some source that the destination radio does not have.

When such file is loaded in the destination radio, the following happens:

  • the source is not found by the parser and set to NONE (= 0)
  • when displaying the mixer lines, the first line with Source = NONE stops the display

If I make a quick & dirty patch to take the Weight into account as well, you can see your missing mixers:

Screenshot 2023-09-03 at 23 11 54

Now the issue is that due to the how we store mixer lines in memory, it gets quite hard to patch so that it always works.
Historically, such mixer lines with Source = 0 never happened, as you cannot choose it on the UI, and OpenTx would not let you load a file from another radio, as the sources were all just numbers and have a specific meaning only in the context of a specific radio.

The easiest way to reproduce is to set the source of a mixer line to NONE. It will hide all the mixer lines starting with that line.

@raphaelcoeffic
Copy link
Member

Oh, and btw: I believe this bug is present for quite some time now (probably as old as the YAML parser).

@paulo-serrao
Copy link

paulo-serrao commented Sep 3, 2023

@raphaelcoeffic, this is the original model file from X9D before I started making changes in the new radio to adjust to new button layout: model02_x9d.zip

The previous file I uploaded was after many changes on other menus/settings and also trying multiples times to set a mix on CH7 to Switch D (just a direct assignment).

PS: On X9D I had CH6 set to Switch G, that switch does not exist on RadioMaster Pocket, maybe that's the root cause? This is how it looks like on my Taranis

Screenshot_2
Screenshot_4

@raphaelcoeffic
Copy link
Member

On X9D I had CH6 set to Switch G, that switch does not exist on RadioMaster Pocket, maybe that's the root cause?

This is it, yes. That transforms it into NONE (--- on screen), which makes the UI think the mixer does not exist, and stops displaying any line after that.

@ValorLin
Copy link

I am using the BetaFPV LiteRadio3 Pro,
After I upgraded to 2.9 yesterday, the issue occurs.
Is there a workaround?

@oloendithas
Copy link

As was mentioned before, the workaround it to create a new model. The issue persists only in models created on pre-2.8 versions.

@raphaelcoeffic
Copy link
Member

@ValorLin @oloendithas as you can see, there is a code change proposed in #4008 which you can try (backup your SD card before, you will need it to go back to 2.9). We need feedback from you guys on that.

@oloendithas
Copy link

We need feedback from you guys on that.

I've recreated my model and can't reproduce the issue any more 🤷🏻‍♂️

@paulo-serrao
Copy link

I am using the BetaFPV LiteRadio3 Pro, After I upgraded to 2.9 yesterday, the issue occurs. Is there a workaround?

You can edit the yaml, clear out the section for the mixer and then recreate it on the radio. (this will avoid having to recreate the whole model and all settings)

@raphaelcoeffic
Copy link
Member

Exactly, the issue is the mixer source NONE. If clear that line, or set it to something meaningful, it works.

@ValorLin
Copy link

ValorLin commented Sep 19, 2023

I am using the BetaFPV LiteRadio3 Pro, After I upgraded to 2.9 yesterday, the issue occurs. Is there a workaround?

You can edit the yaml, clear out the section for the mixer and then recreate it on the radio. (this will avoid having to recreate the whole model and all settings)

Thanks! It works!.
I believe that you guys have caught the problem. @raphaelcoeffic

Below is the original yml that caused this issue.
model03.yml.txt

pfeerick pushed a commit that referenced this issue Sep 24, 2023
…lid sources (#3999)

* fix: mixer lines with empty source

Fixes #3367

* Fix color mixes display.

---------

Co-authored-by: Phil Mitchell <phil.a.mitchell@gmail.com>
pfeerick pushed a commit that referenced this issue Sep 24, 2023
…lid sources (#4008)

* fix: mixer lines with empty source

Backport of #3999, fixes #3367 for 2.9

* Fix color mixes display.

# Conflicts:
#	radio/src/gui/colorlcd/model_mixes.cpp

---------

Co-authored-by: Phil Mitchell <phil.a.mitchell@gmail.com>
gagarinlg pushed a commit that referenced this issue Sep 27, 2023
…lid sources (#3999)

* fix: mixer lines with empty source

Fixes #3367

* Fix color mixes display.

---------

Co-authored-by: Phil Mitchell <phil.a.mitchell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants