Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename lowbatt to lowbat in de-DE.csv #19

Merged
merged 1 commit into from
Apr 18, 2022
Merged

rename lowbatt to lowbat in de-DE.csv #19

merged 1 commit into from
Apr 18, 2022

Conversation

TheIsotopes
Copy link
Contributor

@TheIsotopes TheIsotopes commented Apr 17, 2022

only sounds with 6 letters are shown in the selection menu
the issue is only in this file, all others are fine

only sounds with 6 letters are shown in the selection menu
@TheIsotopes TheIsotopes changed the title rename lowbatt to lowbat rename lowbatt to lowbat in de-DE.csv Apr 17, 2022
@pfeerick pfeerick added this to the 2.7.0 milestone Apr 18, 2022
@pfeerick
Copy link
Member

Nice catch! Thanks :)

@pfeerick pfeerick merged commit 3b2743d into EdgeTX:main Apr 18, 2022
@pfeerick
Copy link
Member

Looks like it's not the only language that is guilty of that... looks like I'll have to do up a validation script also, as it seems like at some point the system lowbatt.wav entry was probably copied by someone, who didn't realise that... custom? ... sounds were limited to six characters when SYSTEM sounds could have more.

@TheIsotopes TheIsotopes deleted the patch-1 branch April 18, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants