Jon/notification-scene #5339
Merged
Jon/notification-scene #5339
+1,341
−4,286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b13b97e to
df78405
Compare
712d40b to
37531b1
Compare
swansontec
requested changes
Jan 24, 2025
0ed439b to
2a0ae50
Compare
swansontec
requested changes
Jan 27, 2025
src/types/types.ts
Outdated
Comment on lines
132
to
159
| export interface NotifInfo { | ||
| /** Timestamp that this notification was detected locally. May accept | ||
| * server-side date values in future iterations. */ | ||
| dateReceived: Date | ||
|
|
||
| /** Whether the user has dismissed the bottom `NotificationView` banner */ | ||
| isBannerHidden: boolean | ||
| /** True if user "completed" the requested action. This may be as simple as | ||
| * tapping and reading the notification, but may be more complex, such as | ||
| * requiring 2FA toggled on. */ | ||
| isCompleted: boolean | ||
| /** True to pin this notification to the top of the `NotificationCenterScene` | ||
| * */ | ||
| isPriority: boolean | ||
| /** Optional object that holds additional parameters that may be used to | ||
| * customize the notification UI. */ | ||
| params?: { walletId: string } | ||
| } |
There was a problem hiding this comment.
Much better! But the whitespace is really weird now.
There are two correct formats:
interface Example {
/** All one line */
something: boolean
/**
* A brief description.
* More details and details and details...
*/
another: boolean
}This comment formatting tradition dates back to the 90's from the old Sun Java days.
2a0ae50 to
e32ea86
Compare
swansontec
approved these changes
Jan 28, 2025
8c20f34 to
50189c3
Compare
- Rename LocalSettingsActions.tsx - Add various notif state functions - Add a watch mechanism for component renders
50189c3 to
2233c41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining issues:
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: