Allow saving Monaco viewstates so they can be restored on re-open. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+86
to
+90
| if (appStateFile == null) { | ||
| return; | ||
| } | ||
|
|
||
| await appStateFile.update(appState); |
There was a problem hiding this comment.
No logic changed here. Just doing some cleanup.
Comment on lines
+48
to
+58
| useEffect(() => { | ||
| store.on("editor.boldSelectedText", boldSelectedText); | ||
| store.on("editor.italicSelectedText", italicSelectedText); | ||
| store.on("editor.setModelViewState", setModelViewState); | ||
|
|
||
| return () => { | ||
| store.off("editor.boldSelectedText", boldSelectedText); | ||
| store.off("editor.italicSelectedText", italicSelectedText); | ||
| store.off("editor.setModelViewState", setModelViewState); | ||
| }; | ||
| }, [store]); |
There was a problem hiding this comment.
This breaks our pattern of subscribing to events at the bottom of the component but I'm not sure of a better way forward.
Depending on the situation we may trigger setModelViewState on the first render so if we set up the listener at the bottom of the component the store throws an error due to not finding the listener.
Maybe we just leave as-is for now? I don't think it's worth changing the pattern yet.
Comment on lines
+148
to
+157
| // dragenter and dragover have to be cancelled in order for the drop event | ||
| // to work on a div. | ||
| const dragEnter = (ev: DragEvent) => { | ||
| ev.stopPropagation(); | ||
| ev.preventDefault(); | ||
| }; | ||
| const dragOver = (ev: DragEvent) => { | ||
| ev.stopPropagation(); | ||
| ev.preventDefault(); | ||
| }; |
There was a problem hiding this comment.
These were pulled into the useEffect hook to avoid regenerating them each render.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deepUpdatenow handles objects with circular references pointing to parents, and also can ignore specific paths.cachein the front end store that lets us save data without triggering re-renders.setModel()on Monaco to improve performance.Editorcomponent.