Handle empty note subdirectories better #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EddieAbbondanzio
commented
Jan 7, 2023
Comment on lines
+362
to
+376
| const metadataPath = p.join( | ||
| noteDirectoryPath, | ||
| entry.name, | ||
| METADATA_FILE_NAME, | ||
| ); | ||
| const markdownPath = p.join( | ||
| noteDirectoryPath, | ||
| entry.name, | ||
| MARKDOWN_FILE_NAME, | ||
| ); | ||
|
|
||
| // Attachment directory doesn't need to be checked because it'll be re-created | ||
| // the first time the user attempts to add an attachment. | ||
|
|
||
| return fs.existsSync(metadataPath) && fs.existsSync(markdownPath); |
There was a problem hiding this comment.
Doesn't need to be in this PR, but we should add some logging here so we can make it easy to tell why a file wasn't loaded, or if there are folders that don't belong in the note directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directories that match the note id regex will now have their contents checked to see if metadata / markdown files exist before attempting to load them.
The app was previously attempting to load empty directories if the directory name matched and it'd crash the app due to expected files not being found.