Track time to prevent erroneous shortcut repeats #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+18
to
+19
| const INITIAL_DELAY_MS = 300; | ||
| const REPEAT_DELAY_MS = 150; |
There was a problem hiding this comment.
Delays were reduced again because they had been previously raised in an attempt to fix this bug. 200 / 400 ms is too slow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortcuts that can be auto repeated by holding down their keys would occasionally fire multiple times producing jumpy results.
This made it frustrating to select items in the sidebar / search via the arrow keys because attempting to move up / down by 1 would often move the selection multiple times.
Reproduced:
Fixed:
