Fix creating notes from context menu (#31)

Fix creating notes so null parent doesn't crash app
EddieAbbondanzio · Jan 6, 2023 · 476f6b7 · 476f6b7
1 parent c34b73f
commit 476f6b7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/shared/domain/note.ts b/src/shared/domain/note.ts
@@ -98,6 +98,11 @@ export function createNote(props: Partial<Note> & Pick<Note, "name">): Note {
   note.dateCreated ??= new Date();
   note.content ??= "";
 
+  // Trim out null parent id
+  if (note.parent === null) {
+    delete note.parent;
+  }
+
   if (!isEmpty(note.children)) {
     for (const child of note.children!) {
       child.parent = note.id;

diff --git a/test/main/ipc/plugins/notes.spec.ts b/test/main/ipc/plugins/notes.spec.ts
@@ -55,6 +55,12 @@ function createMetadata(props?: Partial<NoteMetadata>): NoteMetadata {
   return metadata;
 }
 
+test("createNote", () => {
+  // Trims out null
+  const note = createNote({ name: "foo", parent: null });
+  expect(note).not.toHaveProperty("parent");
+});
+
 test("registers attachment protocol", async () => {
   mockFS({
     [FAKE_NOTE_DIRECTORY]: {},