Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AA-1776] Update the deprecated packages #483

Merged
merged 5 commits into from
Feb 7, 2025
Merged

[AA-1776] Update the deprecated packages #483

merged 5 commits into from
Feb 7, 2025

Conversation

jpardogrowthaccelerationpartners
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Feb 5, 2025

Test Results

84 tests   84 ✅  0s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 3ffdcdd.

♻️ This comment has been updated with latest results.

@@ -213,7 +213,7 @@ jobs:
actions: read
id-token: write
contents: write
uses: Ed-Fi-Alliance-OSS/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@main
uses: Ed-Fi-Alliance-OSS/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@v2.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpardogrowthaccelerationpartners you probably did the same thing in other pull requests and I only noticed it now: why use main on line 174 instead of v2.0.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that was the one that was working in other repositories, that's why I left it with main. But if necessary, I can change the version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that was an accident. Can you try testing in a fork to see if changing to v2.0.0 works on line 174 as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But don't spend a lot of time. This is ok and we can keep it if changing causes any challenges. I might need to investigate more closely at some point in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran it on my fork and main and v2.0.0 fail at the same step.. so I think it won't affect if we change it to v2.0.0

Screenshot 2025-02-07 at 8 58 21 AM

@stephenfuqua stephenfuqua merged commit 21c5aaf into main Feb 7, 2025
8 checks passed
@stephenfuqua stephenfuqua deleted the AA-1776 branch February 7, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants