-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AA-1776] Update the deprecated packages #483
Conversation
Test Results84 tests 84 ✅ 0s ⏱️ Results for commit 3ffdcdd. ♻️ This comment has been updated with latest results. |
@@ -213,7 +213,7 @@ jobs: | |||
actions: read | |||
id-token: write | |||
contents: write | |||
uses: Ed-Fi-Alliance-OSS/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@main | |||
uses: Ed-Fi-Alliance-OSS/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@v2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpardogrowthaccelerationpartners you probably did the same thing in other pull requests and I only noticed it now: why use main
on line 174 instead of v2.0.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that was the one that was working in other repositories, that's why I left it with main. But if necessary, I can change the version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that was an accident. Can you try testing in a fork to see if changing to v2.0.0
works on line 174 as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But don't spend a lot of time. This is ok and we can keep it if changing causes any challenges. I might need to investigate more closely at some point in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.