Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AA-1769] Improve Workflow Permissions #471

Merged
merged 3 commits into from
Jun 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/aa-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ on:
- ".github/workflows/aa-e2e.yml"
- "!Application/EdFi.Ods.Admin.Api" # Need to remove this extra check after we remove EdFi.Ods.Admin.Api project

permissions: read-all

jobs:
run-e2e-tests:
runs-on: ubuntu-latest
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/after-pullrequest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ on:
types:
- completed

permissions: read-all

jobs:
report-test-results:
name: Report Test Results
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/e2e-reports.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ on:
types:
- completed

permissions: read-all

env:
JIRA_ACCESS_TOKEN: ${{ secrets.JIRA_ACCESS_TOKEN }}
ADMIN_APP_VERSION: "3.0.0"
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/on-merge-or-tag.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ on:
tags:
- "v*.*.*"

permissions: read-all

env:
API_URL: https://api.github.com/repos/${{ github.repository }}
TOKEN: ${{ secrets.EDFI_BUILD_AGENT_PAT }}
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/on-prerelease.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ on:
types:
- prereleased

permissions: read-all

env:
ARTIFACTS_API_KEY: ${{ secrets.AZURE_ARTIFACTS_PERSONAL_ACCESS_TOKEN }}
ARTIFACTS_FEED_URL: "https://pkgs.dev.azure.com/ed-fi-alliance/Ed-Fi-Alliance-OSS/_packaging/EdFi/nuget/v3/index.json"
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/on-pullrequest-dockerfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ on:
- "Docker/*"
workflow_dispatch:

permissions: read-all

jobs:
docker-testing:
runs-on: ubuntu-latest
Expand All @@ -39,4 +41,4 @@ jobs:
name: Run Linter on ${{ matrix.dockerfile.name }} Dockerfile
with:
dockerfile: ${{ matrix.dockerfile.path }}
failure-threshold: error
failure-threshold: error
2 changes: 2 additions & 0 deletions .github/workflows/on-pullrequest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ on:
- ".github/**/*.yml"
workflow_dispatch:

permissions: read-all

jobs:
# TODO: restore this with AA-1601
# run-ps-lint:
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/on-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ on:
types:
- released

permissions: read-all

env:
ARTIFACTS_API_KEY: ${{ secrets.AZURE_ARTIFACTS_PERSONAL_ACCESS_TOKEN }}
ARTIFACTS_FEED_URL: "https://pkgs.dev.azure.com/ed-fi-alliance/Ed-Fi-Alliance-OSS/_packaging/EdFi/nuget/v3/index.json"
Expand All @@ -20,6 +22,8 @@ jobs:
delete-pre-releases:
name: Delete Unnecessary Pre-Releases
runs-on: ubuntu-latest
permissions:
contents: write
steps:
- name: Checkout the repo
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
Expand Down Expand Up @@ -74,4 +78,3 @@ jobs:

Import-Module ./eng/promote-packages.psm1
Invoke-Promote @arguments

2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ knowledge of the code base and architecture.

## Legal Information

Copyright (c) 2020 Ed-Fi Alliance, LLC and contributors.
Copyright (c) 2024 Ed-Fi Alliance, LLC and contributors.

Licensed under the [Apache License, Version 2.0](LICENSE) (the "License").

Expand Down
Loading