[ADMINAPI-1085]: Create a shared library code for Admin API #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleiva-gap
commented
Nov 25, 2024
- Create EdFi.Ods.AdminApi.Common library
- Update references between projects
- Move common classes to the new library
- Remove redundant code
- Update nuget packages to remove vulnerabilities
… Admin Console - Create EdFi.Ods.AdminApi.Common library - Move common components to the shared library - Remove redundant code
f66e6f0 to
2f29ae6
Compare
🔍 Vulnerabilities of
|
| digest | sha256:a58711120989dd629f6a0d4003b340761d46f4e66d85bb43ee4cda0d36203f0c |
| vulnerabilities |     |
| platform | linux/amd64 |
| size | 90 MB |
| packages | 602 |
📦 Base Image alpine:3
| also known as |
|
| digest | sha256:33735bd63cf84d7e388d9f6d297d348c523c044410f553bd878c6d7829612735 |
| vulnerabilities |  |
jasonh-edfi
approved these changes
Nov 27, 2024
jagudelo-gap
requested changes
Nov 27, 2024
| { | ||
| public static List<IFeature> GetFeatures() | ||
| public static List<IFeature> GetFeatures2() |
There was a problem hiding this comment.
Is this name correct "GetFeatures2"? It seems this is not required
Removed unused class
jagudelo-gap
approved these changes
Nov 28, 2024
dfernandez-gap
pushed a commit
that referenced
this pull request
Jan 27, 2025
* ADMINAPI-1085 [SPIKE]: Create a shared library code for Admin API and Admin Console - Create EdFi.Ods.AdminApi.Common library - Move common components to the shared library - Remove redundant code * Fix CORS settings * Update nugets to fix vulnerabilities * Update version * Rebase from main branch * Update docker files to include the new library * Update workflow to include new library * Update yml files to include the new library * Delete FeaturesExtensions.cs Removed unused class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.