feat: création d'une molecule Alert
#1198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 4 types : warning, error, info et success - avec ou sans icone - message personnalisable Au passage, simplifie la molecule `Loading`. Configure la taille de l'icone par rapport à la taille du texte. Supprime la notion de `inline` et le padding autour du composant.
✅ Deploy Preview for stylo-docs canceled.
|
ggrossetie
commented
Jan 24, 2025
✅ Deploy Preview for stylo-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ggrossetie
commented
Mar 5, 2025
|
|
||
| function getIcon(type) { | ||
| if (type === 'success') { | ||
| return <CheckCircle color={'rgb(82, 196, 26)'} /> |
There was a problem hiding this comment.
@thom4parisot je n'aime pas trop le fait de déclarer une couleur dans le jsx mais je n'ai pas trouvé comment faire référence à une couleur à partir du scss. Et sauf erreur de ma part, je ne crois pas qu'on puisse changer la couleur via un className sur les icônes feather.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Au passage, simplifie la molecule
Loading.Configure la taille de l'icone par rapport à la taille du texte. Supprime la notion de
inlineet le padding autour du composant.