Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajout du suivi de la couverture de code #1033

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Conversation

thom4parisot
Copy link
Member

La migration vers Vitest ouvre la voie au test des composants React, ce qu'on évitait de faire jusqu'à présent.

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for stylo-docs canceled.

Name Link
🔨 Latest commit 24c9d84
🔍 Latest deploy log https://app.netlify.com/sites/stylo-docs/deploys/670544fd6d006d00086df45f

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for stylo-dev ready!

Name Link
🔨 Latest commit 50468de
🔍 Latest deploy log https://app.netlify.com/sites/stylo-dev/deploys/67053d85b75e8d0008baa25a
😎 Deploy Preview https://deploy-preview-1033--stylo-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thom4parisot thom4parisot force-pushed the feature/code-coverage branch 2 times, most recently from 8edfae7 to c1a3800 Compare October 8, 2024 11:29
@ggrossetie
Copy link
Collaborator

Cela semble lié à coverallsapp/coverage-reporter#30 (comment). Est-ce qu'on peut essayer de configurer le cwd dans .nycrc ?

@thom4parisot
Copy link
Member Author

Oui, je soupçonne le réglage root de la section test de vite.config.js de créer cette confusion. J'avais testé avec le réglage dir mais ça prenait quand même en compte les fichiers du répertoire build (et faisait planter le code coverage ; c'est pour ça que j'ai réglé root).

@thom4parisot thom4parisot force-pushed the feature/code-coverage branch from c1a3800 to 66385fd Compare October 8, 2024 14:08
@thom4parisot thom4parisot force-pushed the feature/code-coverage branch from 66385fd to 50468de Compare October 8, 2024 14:11
@ggrossetie
Copy link
Collaborator

@thom4parisot tu sais si c'est possible de récupérer le lien vers le coverage ? Dans les logs j'ai trouvé https://coveralls.io/builds/70225565 mais ça serait bien si le lien était dispo sur la PR directement

@ggrossetie
Copy link
Collaborator

Et on peut se rajouter le badge sur le README:

[![Coverage Status](https://coveralls.io/repos/github/EcrituresNumeriques/stylo/badge.svg)](https://coveralls.io/github/EcrituresNumeriques/stylo)

Coverage Status

@thom4parisot thom4parisot merged commit 014afe1 into master Oct 8, 2024
10 checks passed
@thom4parisot thom4parisot deleted the feature/code-coverage branch October 8, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants